Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCTP support in the minikube ISO image #12892

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Add SCTP support in the minikube ISO image #12892

merged 4 commits into from
Dec 15, 2021

Conversation

nickolaev
Copy link
Contributor

@nickolaev nickolaev commented Nov 8, 2021 •
edited
Loading

The SCTP protocol is GA since Kubernetes 1.20, https://kubernetes.io/docs/concepts/services-networking/service/#sctp

Fixes #12890

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @nickolaev!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nickolaev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nickolaev nickolaev force-pushed the sctp_support_in_iso branch 2 times, most recently from 1a12161 to f3d4f55 Compare November 10, 2021 13:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 10, 2021
@nickolaev
Copy link
Contributor Author

Bump. Can someone please peek this configuration change?

@nickolaev
Copy link
Contributor Author

/assign @prezha

@sharifelgamal
Copy link
Collaborator

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @nickolaev, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 14, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2021
@sharifelgamal
Copy link
Collaborator

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @nickolaev, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12892) |
+----------------+----------+---------------------+
| minikube start | 46.9s    | 46.2s               |
| enable ingress | 29.6s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.9s 45.2s 45.6s 46.7s 47.4s
Times for minikube (PR 12892) start: 46.4s 46.8s 46.1s 46.1s 45.7s

Times for minikube ingress: 29.2s 29.7s 30.1s 28.7s 30.2s
Times for minikube (PR 12892) ingress: 30.7s 28.7s 30.7s 25.7s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12892) |
+----------------+----------+---------------------+
| minikube start | 28.6s    | 27.3s               |
| enable ingress | 22.9s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 28.1s 27.2s 28.2s 27.9s
Times for minikube (PR 12892) start: 27.5s 27.8s 27.2s 27.3s 26.9s

Times for minikube ingress: 24.0s 22.0s 24.0s 23.0s 21.5s
Times for minikube (PR 12892) ingress: 21.5s 22.5s 23.5s 22.0s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12892) |
+----------------+----------+---------------------+
| minikube start | 41.4s    | 43.0s               |
| enable ingress | 32.3s    | 36.6s               |
+----------------+----------+---------------------+

Times for minikube start: 34.2s 41.5s 42.7s 43.1s 45.7s
Times for minikube (PR 12892) start: 42.1s 42.9s 42.4s 45.5s 42.3s

Times for minikube ingress: 33.0s 33.0s 33.0s 33.4s 29.0s
Times for minikube (PR 12892) ingress: 53.5s 33.0s 33.5s 30.0s 33.0s

sharifelgamal
sharifelgamal approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@sharifelgamal sharifelgamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@sharifelgamal sharifelgamal merged commit a493b59 into kubernetes:master Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickolaev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@medyagh medyagh mentioned this pull request Dec 15, 2021
Merged
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 0.00 (chart)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.83 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.85 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.85 (chart)
Docker_macOS TestSkaffold (gopogh) 0.85 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 1.71 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 1.71 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 2.56 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 3.20 (chart)
Docker_macOS TestAddons/parallel/CSI (gopogh) 4.27 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 4.27 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 5.98 (chart)
Docker_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 6.84 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 6.84 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 6.84 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 9.20 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 9.20 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 9.20 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 9.20 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 11.11 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 11.57 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 16.24 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 20.69 (chart)
Docker_Windows TestPause/serial/PauseAgain (gopogh) 26.51 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 28.41 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 37.04 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 41.03 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 41.03 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 45.45 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees

@prezha prezha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing SCTP support in the minikube VM image
6 participants
@nickolaev @k8s-ci-robot @minikube-bot @sharifelgamal @minikube-pr-bot @prezha