Add support for multiple --mountstring arguments to minikube start --mount

[mans0954]

fixes #12733

Previously minikube start --mount could be passed a --mount-string argument which would create the minikube container with the specified host folder or docker volume mounted at the specified location (provided the minikube container did not already exist). e.g.

minikube start --mount  --mount-string "host_volume:/mount_point"

would mount the host_volume docker volume at /mount_point in the minikube container. If multiple --mount-string arguments were provided, only the last would be used by minikube.

This PR changes minikube so that multiple --mount-string arguments are supported. e.g.

minikube start --mount  --mount-string "host_volume1:/mount_point1"  --mount-string "host_volume2:/mount_point2"

would mount the host_volume1 docker volume at /mount_point1 in the minikube container and host_volume2 at /mount_point2.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @mans0954!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mans0954. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mans0954
To complete the pull request process, please assign medyagh after the PR has been reviewed.
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[mans0954]

Hoping that the CLA is signed now, but it was a confusing process.

[spowelljr]

Hi @mans0954, thanks for creating this PR! While this is a helpful fix, you've only updated the mount code for Docker, and since you updated the flag from a string to string slice it's going to break the existing implementation for our VM drivers.

Here's a link to some of the VM mount code for reference, if you need any help let me know.

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/node/config.go

[mans0954]

Hi @mans0954, thanks for creating this PR! While this is a helpful fix, you've only updated the mount code for Docker, and since you updated the flag from a string to string slice it's going to break the existing implementation for our VM drivers.

Thanks for the feedback - it may be a little while before I have the time to look at this, so if someone else wants to jump in in the meantime, that's fine with me.

[linux-foundation-easycla]

• ❌ - Christopher Hoskin The commit (3459f20) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[klaases]

Hi @mans0954, are you still actively working on this PR?

[mans0954]

Hi @mans0954, are you still actively working on this PR?

Not actively, no. I still think it would be a good improvement if someone else wanted to work on it.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[medyagh]

Hi @mans0954, are you still actively working on this PR?

Not actively, no. I still think it would be a good improvement if someone else wanted to work on it.

no problem, I will close this PR please feel free to reopen whenever you feel ready or if anyone else wants to to pick this up