Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump calico to v3.20 and move away from v1beta apis #12230

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Aug 10, 2021

getting rid of all v1beta apis in our code since it is removed in next kubernetes version
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

I hade to bump the calico version to support the New kubernetes API as part of that I also had to move the string yaml file into go:embed

same refactor needs to be done for other CNIs (to use goembed) but that will be done in separate PRs. this one needed to be done to pass the tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@medyagh
Copy link
Member Author

medyagh commented Aug 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Aug 10, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 48.6s               |
| enable ingress | 31.3s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 12230) start: 48.2s 48.3s 47.5s 51.6s 47.6s
Times for minikube start: 48.7s 47.4s 50.2s 47.4s 47.2s

Times for minikube ingress: 31.2s 31.4s 30.8s 30.8s 32.3s
Times for minikube (PR 12230) ingress: 30.2s 31.3s 30.9s 31.8s 33.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.1s               |
| enable ingress | 30.8s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 22.3s 22.2s 22.0s 21.9s
Times for minikube (PR 12230) start: 22.0s 21.3s 21.7s 22.8s 22.5s

Times for minikube ingress: 27.5s 28.0s 27.0s 37.0s 34.5s
Times for minikube (PR 12230) ingress: 35.0s 32.0s 34.5s 27.5s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 43.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 12230) start: 42.7s 43.8s 43.7s 43.0s 43.9s
Times for minikube start: 27.6s 43.6s 43.8s 44.6s 43.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStoppedBinaryUpgrade (gopogh) n/a
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux_crio TestNetworkPlugins/group/kindnet/NetCatPod (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/kindnet/NetCatPod (gopogh) 0.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
KVM_Linux_containerd TestKubernetesUpgrade (gopogh) 0.00 (chart)
KVM_Linux_containerd TestKVMDriverInstallOrUpdate (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux_crio TestNetworkPlugins/group/calico/Start (gopogh) 0.68 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.94 (chart)
KVM_Linux_crio TestNetworkPlugins/group/calico/Start (gopogh) 1.44 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 2.02 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 2.83 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 2.83 (chart)
Docker_Linux_crio TestKubernetesUpgrade (gopogh) 6.16 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 7.62 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/GCPAuth (gopogh) 7.75 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 8.45 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 8.57 (chart)
KVM_Linux TestNetworkPlugins/group/calico/Start (gopogh) 9.03 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 11.27 (chart)
Docker_Linux_docker_arm64 TestScheduledStopUnix (gopogh) 13.33 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/CSI (gopogh) 13.38 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 13.38 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 14.08 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/bridge/Start (gopogh) 14.29 (chart)
Docker_Linux_docker_arm64 TestNetworkPlugins/group/kubenet/Start (gopogh) 14.29 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/DeployApp2Nodes (gopogh) 15.24 (chart)
Docker_Linux_docker_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 15.24 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 17.12 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@medyagh medyagh changed the title move away from v1beta apis bump calico to v3.20 and move away from v1beta apis Aug 12, 2021
@medyagh
Copy link
Member Author

medyagh commented Aug 12, 2021

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 48.4s               |
| enable ingress | 33.2s    | 36.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.9s 32.3s 33.8s 31.7s 36.2s
Times for minikube (PR 12230) ingress: 33.8s 47.3s 39.3s 32.4s 31.9s

Times for minikube start: 50.2s 46.0s 53.1s 47.2s 46.4s
Times for minikube (PR 12230) start: 46.4s 47.9s 53.0s 47.3s 47.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 22.3s               |
| enable ingress | 32.5s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 22.9s 23.2s 21.7s 22.7s
Times for minikube (PR 12230) start: 23.2s 21.9s 22.2s 22.5s 21.8s

Times for minikube ingress: 30.5s 36.0s 29.5s 35.0s 31.5s
Times for minikube (PR 12230) ingress: 36.0s 32.0s 32.0s 38.5s 32.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 40.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 43.2s 43.6s 43.6s 43.2s
Times for minikube (PR 12230) start: 26.3s 43.9s 43.6s 43.6s 43.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux_crio TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/CSI (gopogh) 1.31 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 1.31 (chart)
KVM_Linux_crio TestNetworkPlugins/group/calico/Start (gopogh) 1.37 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 2.97 (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
KVM_Linux TestNetworkPlugins/group/calico/Start (gopogh) 8.61 (chart)
KVM_Linux_containerd TestPause/serial/PauseAgain (gopogh) 9.09 (chart)
Docker_Linux_crio TestStartStop/group/embed-certs/serial/Pause (gopogh) 9.43 (chart)
Docker_Linux_crio TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 9.80 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/calico/Start (gopogh) 10.20 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 12.67 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 14.13 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Ingress (gopogh) 15.33 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 17.33 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 18.67 (chart)
Docker_Linux_crio TestStartStop/group/no-preload/serial/Stop (gopogh) 23.53 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 24.18 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 33.33 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

timing minikube failed, please try again

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService (gopogh) n/a
Docker_macOS TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.00 (chart)
Docker_macOS TestFunctional/parallel/BuildImage (gopogh) 1.22 (chart)
Docker_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 1.22 (chart)
Docker_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 1.22 (chart)
Docker_macOS TestMultiNode/serial/ProfileList (gopogh) 1.22 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 1.22 (chart)
Docker_macOS TestMultiNode/serial/StopNode (gopogh) 1.22 (chart)
Docker_macOS TestStartStop/group/no-preload/serial/SecondStart (gopogh) 1.30 (chart)
KVM_Linux_crio TestKubernetesUpgrade (gopogh) 1.37 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 1.96 (chart)
Docker_Linux_containerd TestRunningBinaryUpgrade (gopogh) 1.97 (chart)
Docker_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 2.44 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 2.44 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 2.44 (chart)
Docker_macOS TestSkaffold (gopogh) 2.44 (chart)
KVM_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 2.61 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 3.66 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 3.66 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 5.88 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 5.88 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/Pause (gopogh) 6.16 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 6.25 (chart)
KVM_Linux_crio TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 6.29 (chart)
KVM_Linux_containerd TestPause/serial/Pause (gopogh) 6.54 (chart)
KVM_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 6.54 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/Pause (gopogh) 6.54 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 6.54 (chart)
KVM_Linux_crio TestStartStop/group/embed-certs/serial/Pause (gopogh) 6.85 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 53.6s    | 54.5s               |
| enable ingress | 32.8s    | 33.1s               |
+----------------+----------+---------------------+

Times for minikube start: 54.0s 53.2s 52.7s 53.7s 54.4s
Times for minikube (PR 12230) start: 54.0s 52.7s 56.2s 55.4s 54.1s

Times for minikube ingress: 32.0s 32.9s 33.0s 32.5s 33.4s
Times for minikube (PR 12230) ingress: 34.4s 33.5s 32.4s 31.9s 33.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.5s               |
| enable ingress | 29.8s    | 28.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.6s 29.6s 30.6s 26.6s 35.6s
Times for minikube (PR 12230) ingress: 30.6s 27.1s 30.1s 29.6s 26.5s

Times for minikube start: 23.7s 23.4s 23.4s 22.7s 24.0s
Times for minikube (PR 12230) start: 22.7s 23.7s 24.0s 23.7s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12230) |
+----------------+----------+---------------------+
| minikube start | 45.4s    | 41.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.6s 44.4s 44.2s 45.0s 47.7s
Times for minikube (PR 12230) start: 45.1s 44.6s 45.5s 27.3s 44.0s

@medyagh medyagh merged commit 29117e3 into kubernetes:master Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestMultiNode/serial/ProfileList (gopogh) 0.88 (chart)
Hyperkit_macOS TestMultiNode/serial/StopNode (gopogh) 0.88 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 1.20 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/kindnet/ControllerPod (gopogh) 1.35 (chart)
Hyperkit_macOS TestAddons/parallel/CSI (gopogh) 1.75 (chart)
Hyperkit_macOS TestAddons/parallel/Ingress (gopogh) 1.75 (chart)
Hyperkit_macOS TestAddons/parallel/HelmTiller (gopogh) 2.63 (chart)
Hyperkit_macOS TestFunctional/parallel/BuildImage (gopogh) 2.65 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 2.65 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 3.70 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 4.42 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 4.42 (chart)
Hyperkit_macOS TestMultiNode/serial/DeleteNode (gopogh) 5.56 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 5.56 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 7.08 (chart)
Docker_Linux_crio TestNetworkPlugins/group/calico/DNS (gopogh) 7.95 (chart)
Hyperkit_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 7.96 (chart)
KVM_Linux TestMultiNode/serial/DeleteNode (gopogh) 8.67 (chart)
Hyperkit_macOS TestMultiNode/serial/AddNode (gopogh) 8.77 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 9.52 (chart)
KVM_Linux TestMultiNode/serial/RestartKeepsNodes (gopogh) 10.00 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 10.53 (chart)
Hyperkit_macOS TestMultiNode/serial/StartAfterStop (gopogh) 10.53 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/BuildImage (gopogh) 11.03 (chart)
Hyperkit_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 11.40 (chart)
Hyperkit_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 11.40 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 12.28 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 14.04 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/Start (gopogh) 14.91 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 15.13 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants