-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: support renaming binary to kubectl.exe
and running as kubectl
#11819
windows: support renaming binary to kubectl.exe
and running as kubectl
#11819
Conversation
7c22929
to
fdca7d6
Compare
kubectl.exe
and running as kubectl
/ok-to-test |
kubectl.exe
and running as kubectlkubectl.exe
and running as kubectl
kubectl.exe
and running as kubectlkubectl.exe
and running as kubectl
/ok-to-test |
1 similar comment
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 51.1s 48.2s 48.5s 46.8s 50.3s Times for minikube (PR 11819) ingress: 34.7s 33.8s 35.2s 32.8s 35.2s docker driver with docker runtime
Times for minikube (PR 11819) start: 21.6s 22.0s 22.5s 21.1s 23.0s Times for minikube ingress: 32.5s 31.5s 27.0s 29.5s 32.0s docker driver with containerd runtime
Times for minikube start: 31.7s 47.4s 43.0s 46.9s 44.3s |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #11838
We support renaming the minikube binary to
kubectl
and the binary will run as kubectl. However, we don't support renaming the binary tokubectl.exe
on Windows and running as kubectl.This PR adds support for this and also makes the the Windows test pass.