gcp-auth: do not override existing environment variables in pods #11665

sharifelgamal · 2021-06-15T21:37:23Z

sharifelgamal · 2021-06-15T21:56:43Z

/ok-to-test

minikube-pr-bot · 2021-06-15T23:11:24Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 47.9s    | 48.4s               |
| enable ingress | 38.3s    | 39.6s               |
+----------------+----------+---------------------+

Times for minikube start: 47.9s 47.9s 50.1s 46.3s 47.4s
Times for minikube (PR 11665) start: 46.7s 51.8s 46.9s 50.6s 45.7s

Times for minikube (PR 11665) ingress: 35.7s 42.7s 34.8s 42.2s 42.3s
Times for minikube ingress: 35.3s 34.2s 43.8s 42.2s 36.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 22.0s               |
| enable ingress | 34.3s    | 34.1s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.7s 20.7s 22.1s 21.4s
Times for minikube (PR 11665) start: 23.7s 21.0s 21.5s 22.5s 21.1s

Times for minikube ingress: 31.5s 32.5s 35.5s 38.0s 34.0s
Times for minikube (PR 11665) ingress: 33.5s 38.0s 31.5s 33.5s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 45.9s    | 46.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 47.6s 47.3s 43.5s 47.4s 43.8s
Times for minikube (PR 11665) start: 44.7s 47.3s 47.3s 43.8s 47.1s

medyagh · 2021-06-16T16:35:46Z

Docker Linux and Docker Linux Containerd tested need to be restared

sharifelgamal · 2021-06-16T17:03:41Z

/ok-to-test

minikube-pr-bot · 2021-06-16T17:52:11Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 49.8s    | 48.0s               |
| enable ingress | 34.5s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube start: 50.7s 50.1s 49.6s 48.0s 50.5s
Times for minikube (PR 11665) start: 48.1s 48.0s 47.8s 48.0s 47.9s

Times for minikube ingress: 35.3s 33.3s 33.7s 35.3s 34.8s
Times for minikube (PR 11665) ingress: 33.7s 34.2s 34.8s 36.7s 34.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.8s               |
| enable ingress | 29.8s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 21.8s 22.3s 22.3s 22.5s
Times for minikube (PR 11665) start: 22.1s 21.9s 21.9s 21.3s 22.1s

Times for minikube ingress: 30.0s 32.0s 29.0s 28.5s 29.5s
Times for minikube (PR 11665) ingress: 31.5s 29.5s 31.5s 27.5s 29.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 41.8s    | 46.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 43.4s 43.1s 47.7s 43.4s
Times for minikube (PR 11665) start: 48.3s 43.7s 47.5s 43.6s 47.8s

sharifelgamal · 2021-06-16T21:27:33Z

/ok-to-test

minikube-pr-bot · 2021-06-16T23:08:08Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 48.1s               |
| enable ingress | 35.4s    | 34.5s               |
+----------------+----------+---------------------+

Times for minikube start: 47.8s 46.8s 49.4s 47.2s 47.2s
Times for minikube (PR 11665) start: 49.5s 47.3s 47.9s 48.2s 47.5s

Times for minikube ingress: 34.3s 41.7s 35.2s 32.2s 33.8s
Times for minikube (PR 11665) ingress: 34.3s 34.2s 34.2s 33.7s 36.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 22.2s               |
| enable ingress | 29.3s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 11665) start: 21.4s 22.4s 22.7s 22.4s 22.1s
Times for minikube start: 20.7s 21.1s 21.5s 21.9s 22.2s

Times for minikube ingress: 29.0s 29.0s 31.0s 28.5s 29.0s
Times for minikube (PR 11665) ingress: 29.0s 29.5s 30.5s 28.5s 29.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 45.7s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.1s 47.1s 43.3s 43.0s 47.2s
Times for minikube (PR 11665) start: 42.6s 42.2s 46.9s 42.7s 43.6s

sharifelgamal · 2021-06-17T18:28:53Z

/ok-to-test

…-0.0.6

minikube-pr-bot · 2021-06-17T19:22:18Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 49.9s    | 48.3s               |
| enable ingress | 34.1s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 51.9s 53.0s 47.5s 47.3s
Times for minikube (PR 11665) start: 47.4s 48.9s 47.2s 49.0s 49.1s

Times for minikube ingress: 33.9s 34.4s 33.7s 33.8s 34.7s
Times for minikube (PR 11665) ingress: 34.7s 34.3s 33.3s 33.3s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.4s               |
| enable ingress | 30.0s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 20.8s 22.8s 22.6s 22.6s
Times for minikube (PR 11665) start: 21.6s 23.1s 22.1s 22.9s 22.2s

Times for minikube ingress: 30.0s 29.5s 33.5s 28.0s 29.0s
Times for minikube (PR 11665) ingress: 29.6s 32.5s 28.5s 28.5s 28.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 42.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.6s 43.2s 43.4s 43.3s 43.1s
Times for minikube (PR 11665) start: 48.4s 43.3s 47.3s 43.5s 30.6s

minikube-bot · 2021-06-17T19:26:20Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)

minikube-bot · 2021-06-17T19:31:43Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestStartStop/group/newest-cni/serial/Pause	0.00 (chart)
TestStartStop/group/newest-cni/serial/SecondStart	0.00 (chart)
TestStartStop/group/newest-cni/serial/VerifyKubernetesImages	0.00 (chart)

minikube-bot · 2021-06-17T19:41:26Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)

minikube-pr-bot · 2021-06-17T19:42:13Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 49.9s    | 50.5s               |
| enable ingress | 35.0s    | 37.6s               |
+----------------+----------+---------------------+

Times for minikube start: 53.8s 48.0s 54.1s 46.4s 47.4s
Times for minikube (PR 11665) start: 55.2s 47.2s 49.3s 52.2s 48.7s

Times for minikube ingress: 34.9s 35.8s 34.3s 35.3s 34.8s
Times for minikube (PR 11665) ingress: 35.4s 36.9s 36.3s 35.8s 43.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 24.4s               |
| enable ingress | 31.7s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 24.6s 23.5s 23.7s 23.9s
Times for minikube (PR 11665) start: 24.7s 24.2s 23.5s 25.6s 23.9s

Times for minikube ingress: 33.1s 30.6s 32.1s 30.1s 32.7s
Times for minikube (PR 11665) ingress: 28.6s 30.6s 34.1s 35.6s 31.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 46.2s    | 48.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 34.4s 49.4s 48.9s 49.3s 48.8s
Times for minikube (PR 11665) start: 45.1s 49.6s 48.0s 49.3s 48.2s

minikube-bot · 2021-06-17T19:43:03Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)

minikube-bot · 2021-06-17T19:52:09Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestErrorSpam/setup	100.00 (chart)

minikube-bot · 2021-06-17T19:54:25Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestAddons/parallel/GCPAuth	0.00 (chart)

minikube-bot · 2021-06-17T20:49:32Z

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests	Flake Rate (%)

minikube-bot · 2021-06-17T21:04:23Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestErrorSpam/setup	100.00 (chart)

medyagh · 2021-06-18T15:52:15Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests Flake Rate (%)
TestAddons/parallel/GCPAuth 0.00 (chart)

this seems to be relevent to this PR ?

sharifelgamal · 2021-06-18T16:20:35Z

These are the flake rates of all failed tests on Docker_Linux_containerd.
Failed Tests Flake Rate (%)
TestAddons/parallel/GCPAuth 0.00 (chart)

this seems to be relevent to this PR ?

I'm looking into it yeah

sharifelgamal · 2021-06-18T16:48:39Z

/ok-to-test

minikube-pr-bot · 2021-06-18T18:24:19Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 54.1s    | 52.2s               |
| enable ingress | 39.5s    | 40.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 11665) start: 51.2s 51.2s 49.8s 57.3s 51.2s
Times for minikube start: 55.5s 53.3s 51.8s 56.0s 53.9s

Times for minikube ingress: 43.4s 43.3s 41.3s 34.9s 34.8s
Times for minikube (PR 11665) ingress: 42.4s 42.3s 44.8s 37.9s 35.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.3s               |
| enable ingress | 33.9s    | 32.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.5s 34.5s 31.5s 37.5s 33.5s
Times for minikube (PR 11665) ingress: 32.5s 36.5s 28.5s 34.5s 31.0s

Times for minikube start: 22.2s 23.0s 22.5s 21.0s 22.2s
Times for minikube (PR 11665) start: 22.8s 22.4s 21.8s 22.2s 22.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11665) |
+----------------+----------+---------------------+
| minikube start | 45.6s    | 45.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 46.0s 44.2s 43.1s 47.1s 47.6s
Times for minikube (PR 11665) start: 44.2s 43.6s 47.7s 43.0s 48.4s

minikube-bot · 2021-06-18T18:45:28Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestErrorSpam/setup	100.00 (chart)

k8s-ci-robot · 2021-06-21T16:41:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Upgrade gcp-auth-webhook to v0.0.6

ed42a7b

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021

k8s-ci-robot requested review from medyagh and RA489 June 15, 2021 21:37

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 15, 2021

Merge branch 'master' of github.com:kubernetes/minikube into gcp-auth…

1e0ce5c

…-0.0.6

medyagh approved these changes Jun 21, 2021

View reviewed changes

medyagh merged commit 40fc9cd into kubernetes:master Jun 21, 2021

sharifelgamal changed the title ~~Upgrade gcp-auth-webhook to v0.0.6~~ gcp-auth: do not override existing environment variables in pods Jun 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gcp-auth: do not override existing environment variables in pods #11665

gcp-auth: do not override existing environment variables in pods #11665

sharifelgamal commented Jun 15, 2021

sharifelgamal commented Jun 15, 2021

minikube-pr-bot commented Jun 15, 2021

medyagh commented Jun 16, 2021

sharifelgamal commented Jun 16, 2021

minikube-pr-bot commented Jun 16, 2021

sharifelgamal commented Jun 16, 2021

minikube-pr-bot commented Jun 16, 2021

sharifelgamal commented Jun 17, 2021

minikube-pr-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-pr-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

medyagh commented Jun 18, 2021

sharifelgamal commented Jun 18, 2021

sharifelgamal commented Jun 18, 2021

minikube-pr-bot commented Jun 18, 2021

minikube-bot commented Jun 18, 2021

k8s-ci-robot commented Jun 21, 2021

gcp-auth: do not override existing environment variables in pods #11665

gcp-auth: do not override existing environment variables in pods #11665

Conversation

sharifelgamal commented Jun 15, 2021

sharifelgamal commented Jun 15, 2021

minikube-pr-bot commented Jun 15, 2021

medyagh commented Jun 16, 2021

sharifelgamal commented Jun 16, 2021

minikube-pr-bot commented Jun 16, 2021

sharifelgamal commented Jun 16, 2021

minikube-pr-bot commented Jun 16, 2021

sharifelgamal commented Jun 17, 2021

minikube-pr-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-pr-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

minikube-bot commented Jun 17, 2021

medyagh commented Jun 18, 2021

sharifelgamal commented Jun 18, 2021

sharifelgamal commented Jun 18, 2021

minikube-pr-bot commented Jun 18, 2021

minikube-bot commented Jun 18, 2021

k8s-ci-robot commented Jun 21, 2021