metallb-addon: Update metallb from 0.8.2 to 0.9.6

[r4j4h]

This change isn't strictly necessary but the newer versions of metallb contain some really nice quality of life improvements, and better support newer (installed by default) versions of kubernetes better.

A sample of some improvements this brings to metallb add-on installed by minikube:

• Layer2 doesn't update when when ip changes - this hit me, and might be hitting others
• Allow spaces in configs - quality of life
• selflink is deprecated - Kubernetes deprecation (seeing this is in the logs is what originally caused me to look into upgrading it)

Note: Happy to update any relevant tests, I didn't see any for this but I didn't look THAT closely, just let me know. I've been running this successfully with minikube addons enable metallb --images="Controller=metallb/controller:v0.9.6,Speaker=metallb/speaker:v0.9.6" for days now.

[k8s-ci-robot]

Welcome @r4j4h!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @r4j4h. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: r4j4h
To complete the pull request process, please assign medyagh after the PR has been reviewed.
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@r4j4h thank you for this PR ! it looks doing the the right thing, admit-ably I haven't used this addon myself and wouldn't know what is a good way to test it.

do you mind sharing an example of using metallb in the PR description ? it could be helpful to others who wanna learn metallb with minikbue. maybe we could have an entry about metalb in our tutorials https://minikube.sigs.k8s.io/docs/tutorials/

ideally we should have had a sub test for MetalLb in our TestAddons located here https://github.com/medyagh/minikube/blob/1be59b8f23c66d9a6be174dcd579b17302857f5f/test/integration/addons_test.go#L65

[medyagh]

/ok-to-test

[k8s-ci-robot]

@r4j4h: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-minikube-build	e0838eb	link	/test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11410) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 45.5s               |
| enable ingress | 39.8s    | 36.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 11410) ingress: 35.2s 35.7s 42.7s 34.8s 34.7s
Times for minikube ingress: 36.7s 42.7s 34.2s 42.2s 43.2s

Times for minikube start: 48.0s 47.1s 46.5s 47.1s 46.2s
Times for minikube (PR 11410) start: 46.4s 45.3s 45.1s 45.4s 45.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11410) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.7s               |
| enable ingress | 35.1s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 21.6s 21.1s 21.1s 21.2s
Times for minikube (PR 11410) start: 21.3s 22.4s 21.9s 21.0s 22.0s

Times for minikube ingress: 32.5s 32.9s 39.0s 33.5s 37.5s
Times for minikube (PR 11410) ingress: 34.0s 33.0s 32.5s 35.5s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11410) |
+----------------+----------+---------------------+
| minikube start | 43.4s    | 45.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 42.2s 42.7s 46.8s 42.9s 42.1s
Times for minikube (PR 11410) start: 49.0s 43.1s 43.2s 46.8s 43.0s

[medyagh]

Looks good to me @r4j4h , Thank you for this PR and improving minikube,

[r4j4h]

Sorry for not seeing your feedback sooner medyagh! Time can be so sparse, especially when there are other pressing issues. It was my pleasure contributing, and I hope to again soon. I will try to circle back around and add metallb to the stub soon.