-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a quiz-style installation instructions #11399
Conversation
Hi @dinever. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5db2855
to
6808ccf
Compare
Can one of the admins verify this patch? |
6808ccf
to
487b4a3
Compare
@@ -23,7 +23,7 @@ $gray-800: #333 !default; | |||
$gray-900: #222 !default; | |||
$black: #000 !default; | |||
|
|||
$primary: #f2771a !default; | |||
$primary: $mk-dark !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this primary
color is actually used anywhere, and it's orange. So I changed it to our theme color which is the k8s blue.
@dinever thank you very much for taking this task ! I am so happy to see this page getting simplified, |
bd422da
to
606bf94
Compare
606bf94
to
109875d
Compare
Thanks! I've fixed the build failure. I have to upgrade our Hugo version from The site is now available for preview at: https://deploy-preview-11399--kubernetes-sigs-minikube.netlify.app/docs/start/ Thanks! |
@dinever: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Peixuan Ding <[email protected]>
Signed-off-by: Peixuan Ding <[email protected]>
109875d
to
28915b0
Compare
@dinever thank you very much this looks much much better ! Is it possible that we have a default case on first view ? And also we used to have an auto detection for Mac and Linux and windows.... Does this pr preserve that ? |
Thanks! It auto-detects the OS and chooses it for the user. I've tested on Linux and macOS and the auto-detection worked as expected. Will test on Windows, too.
Sounds good. I can make it go one step further:
|
Hi @medyagh, I've pushed the latest commit cc0d065 to make sure the first option of each row is auto-selected (OS->x86->binary download). In addition, I've confirmed that OS auto-detection works for all 3 platforms. This way we can minimize the number of clicks users need to perform. Please see the following GIF for a quick demo, and feel to try it at https://deploy-preview-11399--kubernetes-sigs-minikube.netlify.app/docs/start/. Thanks a lot for the feedback! |
thank you very much @dinever it looks great, only thing is, possible to make the whole Install Section have a different background color simmilar to old way ? a light green/blue-ish ? btw in another note, not related to this PR but I wish our Boxes were not too long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do u mind also pasting screenshot for a user who has disabled JavaScript, will it still have an acceptable look in case of no javascript ?
@dinever here is the screenshot without Javascript, could we make it in a way that a user without javascript can see the default page (even if it is ugly) ? |
Hi all, Thanks for the feedback! I've pushed the latest commits:
Feel free to try the preview site at https://deploy-preview-11399--kubernetes-sigs-minikube.netlify.app/docs/start/. Thanks a lot! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinever, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you very much @dinever |
looks amazing |
Hi,
This PR fixes #10353, see #10353 (comment)
The idea is to add a "quiz" style installation page. Inspired by CUDA and PyTorch:
Showcase:
Some features:
ARMv7
,ppc64
andS390x
architecture under Linux as wellWould love to hear some feedback! Thanks!