UI: Add progressbar when downloading kic base image

[afbjorklund]

✨  Automatically selected the docker driver. Other choices: kvm2, podman, virtualbox, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
    > gcr.io/k8s-minikube/kicbase...: 61.10 MiB / 353.96 MiB  17.26% 5.19 MiB p^C

Closes #7012

[afbjorklund]

Support for tarball was added in google/go-containerregistry#675

For daemon submitted upstream as google/go-containerregistry#972

[afbjorklund]

Sadly this breaks the digest handling, so the image is downloaded over-and-over instead

/hold

[afbjorklund]

Apparently had an old image in the cache or something, because it worked now...

first start

Checking for gcr.io/k8s-minikube/kicbase:v0.0.18@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e in local docker daemon
🚜  Pulling base image ...
Writing image gcr.io/k8s-minikube/kicbase:v0.0.18@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e
    > gcr.io/k8s-minikube/kicbase...: 353.96 MiB / 353.96 MiB  100.00% 12.10 Mi
successfully downloaded gcr.io/k8s-minikube/kicbase:v0.0.18@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e

[
    {
        "Id": "sha256:a776c544501ab7f8d55c0f9d8df39bc284df5e744ef1ab4fa59bbd753c98d5f6",
        "RepoTags": [
            "gcr.io/k8s-minikube/kicbase:v0.0.18"
        ],
        "RepoDigests": [
            "gcr.io/k8s-minikube/kicbase@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e"
        ],

second start

I0321 15:52:29.765944 1843801 image.go:90] Checking for gcr.io/k8s-minikube/kicbase:v0.0.18@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e in local docker daemon
I0321 15:52:29.833259 1843801 image.go:94] Found gcr.io/k8s-minikube/kicbase:v0.0.18@sha256:ddd0c02d289e3a6fb4bba9a94435840666f4eb81484ff3e707b69c1c484aa45e in local docker daemon, skipping pull

/unhold

[afbjorklund]

It seems like it is the "--download-only" that is broken, it doesn't update the digest.

Docker never does that when loading from a tarball, like go-containerregistry does.

When using the normal start, it will continue and let docker tag the image properly.

i.e. it will be without a digest initially, but the docker run will add it during start.

[afbjorklund]

Fixed the image digest, with the usual pull after load workaround

Now you can do --download-only multiple times without re-downloading.

$ ./out/minikube start --download-only
😄  minikube v1.18.1 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
    > gcr.io/k8s-minikube/kicbase...: 353.96 MiB / 353.96 MiB  100.00% 9.39 MiB
✅  Download complete!
$ ./out/minikube start --download-only
😄  minikube v1.18.1 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
✅  Download complete!

Before it would start over again, due to the missing digest after daemon.Write.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment