-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0) #10879
Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0) #10879
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @afbjorklund |
Can one of the admins verify this patch? |
/ok-to-test |
kvm2 Driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: govargo, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you for refreshing the ingress addon |
Ingress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx. Since the output result has also changed, I decided to display only one line. minikube 1.19.0 Upgrade ingress addon files according to upstream. https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05 kubernetes/minikube#10879 Before --- NAME READY STATUS RESTARTS AGE default-http-backend-59868b7dd6-xb8tq 1/1 Running 0 1m kube-addon-manager-minikube 1/1 Running 0 3m kube-dns-6dcb57bcc8-n4xd4 3/3 Running 0 2m kubernetes-dashboard-5498ccf677-b8p5h 1/1 Running 0 2m nginx-ingress-controller-5984b97644-rnkrg 1/1 Running 0 1m storage-provisioner 1/1 Running 0 2m --- After --- NAME READY STATUS RESTARTS AGE ingress-nginx-controller-75fbcbcc56-q7lg8 1/1 Running 0 4h41m ---
minikube 1.19.0 Upgrade ingress addon files according to upstream. https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05 kubernetes/minikube#10879
ngress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx. Since the output result has also changed, I decided to display only one line. minikube 1.19.0 Upgrade ingress addon files according to upstream. https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05 kubernetes/minikube#10879
ngress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx. Since the output result has also changed, I decided to display only one line. minikube 1.19.0 Upgrade ingress addon files according to upstream. https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05 kubernetes/minikube#10879
Ingress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx. Since the output result has also changed, I decided to display only one line. minikube 1.19.0 Upgrade ingress addon files according to upstream. https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05 kubernetes/minikube#10879
What type of PR is this?
/area addons
/kind cleanup
What this PR does / why we need it:
This PR upgrades ingress addon according to upstream(kubernets/ingress-nginx).
Our minikube's ingress manifest files are very old, because they have been held since 2016, f1fb26a.
Our ingress addon's manifests are very different from upstream ones.
So, there are many differnces in this PR...
This PR upgrade ingress addon's version and K8s apiVersions.
Which issue(s) this PR fixes:
Fix #10855
Does this PR introduce a user-facing change?
Yes, this PR change ingress addon's version(to v0.44.0) and K8s apiVersions.
Before this PR
After this PR
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: