add docker-env and podman-env to minikube status

[tharun208]

Signed-off-by: Tharun [email protected]

Before: minikube status

After: minikube docker-env and minikube-status and minikube docker-env --unset

minikube status --output=json result:

Fixes #6535

[k8s-ci-robot]

Hi @tharun208. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

would u plz add before after this PR in the descripttion ?
how about adding an integreation test ?
we already do docker-env status here
we could add another check that checks for this New Test to be showing

here is the code

		c := exec.CommandContext(mctx, "/bin/bash", "-c", "eval $("+Target()+" -p "+profile+" docker-env) && "+Target()+" status -p "+profile)
		// we should be able to get minikube status with a bash which evaled docker-env
		rr, err = Run(t, c)

we could add a check for the output of rr
https://github.com/medyagh/minikube/blob/f95d43a2c78070ab10a4e7d134ff2d0952a5ca86/test/integration/functional_test.go#L261

[medyagh]

lets add same thing for podman-env

[medyagh]

Do you mind pasting the out of minikube status --output=json
And can we ensure the json output has it too?

[medyagh]

This should not be part of config. Because in one terminal it might be in use and other terminal not but config is global. So let's remove it

[tharun208]

@medyagh, without the config change. can you help me with how we can implement this for podman?

for docker, we can make use of this MINIKUBE_ACTIVE_DOCKERD env variable at runtime to check if it is the same as the cluster name.

[medyagh]

For podman u could see the podman-env.go file

But also lets make sure the minikbue Config does not have that DockerEnvInUse ...

[tharun208]

@medyagh, I updated the code without making any changes to the config. But, I am not able to update the functional test as it fails locally.

[medyagh]

Any reason this was moved up ? If not revert the unrelated changes

[medyagh]

thank you for this contribution @tharun208

[medyagh]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tharun208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10872): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10872/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10872/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10872): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10872/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10872/minikube: exec format error