-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add control-plane to NO_PROXY for docker/podman drivers #10046
Conversation
Signed-off-by: Ling Samuel <[email protected]>
Hi @lingsamuel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lingsamuel thank you very much for this PR,
do u mind pasting the out of minikube after this PR. and verify that the proxy env was added ?
to do that u can do
make kic-base-image
minikube start --base-image="...the name of the image that was produced in last step...which starts with local/kicbase..."
then u can do
minikube ssh
and cat the systemfile to show that it is there
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing this
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingsamuel, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ling Samuel [email protected]
We should make sure api endpoint exists in NO_PROXY.
With noProxy in .docker/config.json:
without noProxy in .docker/config.json: