Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFS support to "minikube mount" #4324

Closed
tstromberg opened this issue May 22, 2019 · 11 comments
Closed

Add NFS support to "minikube mount" #4324

tstromberg opened this issue May 22, 2019 · 11 comments
Labels
area/mount help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@tstromberg
Copy link
Contributor

"minikube mount" only supports 9pfs at the moment. It wouldn't be difficult to add NFS support, which is much faster.

On platforms where NFS is supported, it should be the default, as 9p has many issues.
@tstromberg tstromberg added area/mount priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. r/2019q2 Issue was last reviewed 2019q2 labels May 22, 2019
@pswica
Copy link

pswica commented May 24, 2019

Could I help out with this? I'm still a bit new to open source but would love to give this a shot, or at least play some part getting this feature on minikube. Any guidance would be greatly appreciated.

@teejae
Copy link
Contributor

teejae commented May 28, 2019

@tstromberg Do you have examples on Linux of what the NFS mount line should look like? I could give this a shot as well. I'm on a Mac, but lots of my coworkers are on Linux, and I wanna help them out.

@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@tstromberg
Copy link
Contributor Author

@teejae - Linux uses /etc/exports - for some examples, see: http://nfs.sourceforge.net/nfs-howto/ar01s03.html

If you or anyone else implements this for macOS, that would be a great start.

It's worth noting that the hyperkit driver has some hacky unstable support for doing NFS, but conceptually, this should be possible across hypervisors. This may help you get started:

minikube/pkg/drivers/hyperkit/driver.go

Line 428 in a817bff

func (d *Driver) setupNFSShare() error {

@tstromberg tstromberg mentioned this issue Sep 4, 2019
Closed
@tstromberg tstromberg mentioned this issue Sep 20, 2019
Open
@tstromberg tstromberg removed the r/2019q2 Issue was last reviewed 2019q2 label Sep 20, 2019
This was referenced Sep 20, 2019
Closed
Closed
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 21, 2019
@tstromberg tstromberg added this to the v1.6.0-candidate milestone Oct 21, 2019
@tstromberg tstromberg modified the milestones: v1.6.0, v1.7.0-candidate Oct 30, 2019
@tstromberg tstromberg removed this from the v1.7.0-candidate milestone Dec 9, 2019
@medyagh
Copy link
Member

medyagh commented Dec 16, 2019

we still wanna do this, and this still a help wanted issue

@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 16, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 5, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2020
@medyagh
Copy link
Member

medyagh commented May 20, 2020 •
edited
Loading

this is still a Wanted issue, anyone interested to help, I would be happy to review it

@afbjorklund afbjorklund mentioned this issue May 21, 2020
Closed
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 19, 2020
@priyawadhwa priyawadhwa removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 8, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 5, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/mount help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@tstromberg @teejae @medyagh @priyawadhwa @pswica @k8s-ci-robot @sharifelgamal @fejta-bot