Skip to content

Commit

Permalink
Replace k8s.gcr.io with registry.k8s.io
Browse files Browse the repository at this point in the history
  • Loading branch information
mrbobbytables committed Feb 2, 2023
1 parent bd235db commit eb0cbbb
Show file tree
Hide file tree
Showing 25 changed files with 207 additions and 207 deletions.
122 changes: 61 additions & 61 deletions deploy/addons/aliyun_mirror.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion deploy/addons/gpu/nvidia-driver-installer.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,5 @@ spec:
- name: root-mount
mountPath: /root
containers:
- image: "{{default "k8s.gcr.io" .ImageRepository}}/{{.Images.Pause}}"
- image: "{{default "registry.k8s.io" .ImageRepository}}/{{.Images.Pause}}"
name: pause
2 changes: 1 addition & 1 deletion deploy/addons/gvisor/gvisor-config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ oom_score = 0
stream_server_address = ""
stream_server_port = "10010"
enable_selinux = false
sandbox_image = "{{default "k8s.gcr.io" .ImageRepository}}/pause:3.1"
sandbox_image = "{{default "registry.k8s.io" .ImageRepository}}/pause:3.1"
stats_collect_period = 10
systemd_cgroup = false
enable_tls_streaming = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ oom_score = 0
stream_server_address = ""
stream_server_port = "10010"
enable_selinux = false
sandbox_image = "k8s.gcr.io/pause:3.6"
sandbox_image = "registry.k8s.io/pause:3.6"
stats_collect_period = 10
enable_tls_streaming = false
max_container_log_line_size = 16384
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ oom_score = 0
stream_server_address = ""
stream_server_port = "10010"
enable_selinux = false
sandbox_image = "k8s.gcr.io/pause:3.6"
sandbox_image = "registry.k8s.io/pause:3.6"
stats_collect_period = 10
enable_tls_streaming = false
max_container_log_line_size = 16384
Expand Down
2 changes: 1 addition & 1 deletion deploy/iso/minikube-iso/package/crio-bin/crio.conf
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ global_auth_file = ""

# The image used to instantiate infra containers.
# This option supports live configuration reload.
pause_image = "k8s.gcr.io/pause:3.2"
pause_image = "registry.k8s.io/pause:3.2"

# The path to a file containing credentials specific for pulling the pause_image from
# above. The file is similar to that of /var/lib/kubelet/config.json
Expand Down
2 changes: 1 addition & 1 deletion deploy/iso/minikube-iso/package/crio-bin/crio.conf.default
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ global_auth_file = ""

# The image used to instantiate infra containers.
# This option supports live configuration reload.
pause_image = "k8s.gcr.io/pause:3.2"
pause_image = "registry.k8s.io/pause:3.2"

# The path to a file containing credentials specific for pulling the pause_image from
# above. The file is similar to that of /var/lib/kubelet/config.json
Expand Down
2 changes: 1 addition & 1 deletion deploy/kicbase/containerd.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ oom_score = 0
stream_server_address = ""
stream_server_port = "10010"
enable_selinux = false
sandbox_image = "k8s.gcr.io/pause:3.6"
sandbox_image = "registry.k8s.io/pause:3.6"
stats_collect_period = 10
enable_tls_streaming = false
max_container_log_line_size = 16384
Expand Down
2 changes: 1 addition & 1 deletion pkg/addons/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ func supportLegacyIngress(addon *assets.Addon, cc config.ClusterConfig) error {
"KubeWebhookCertgenPatch": "docker.io/jettech/kube-webhook-certgen:v1.5.1@sha256:950833e19ade18cd389d647efb88992a7cc077abedef343fa59e012d376d79b7",
}
addon.Registries = map[string]string{
"IngressController": "k8s.gcr.io",
"IngressController": "registry.k8s.io",
}
return nil
}
Expand Down
36 changes: 18 additions & 18 deletions pkg/minikube/assets/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ var Addons = map[string]*Addon{
"Alpine": "alpine:3.6@sha256:66790a2b79e1ea3e1dabac43990c54aca5d1ddf268d9a5a0285e4167c8b24475",
"Kibana": "kibana/kibana:5.6.2@sha256:cd948a9bda4622f1437afc4a3e78be6c8c25fc62f40aa0376f3d690f2436568f",
}, map[string]string{
"Elasticsearch": "k8s.gcr.io",
"FluentdElasticsearch": "k8s.gcr.io",
"Elasticsearch": "registry.k8s.io",
"FluentdElasticsearch": "registry.k8s.io",
"Kibana": "docker.elastic.co",
"Alpine": "docker.io",
}),
Expand Down Expand Up @@ -436,8 +436,8 @@ var Addons = map[string]*Addon{
"NvidiaDriverInstaller": "minikube-nvidia-driver-installer:e2d9b43228decf5d6f7dce3f0a85d390f138fa01",
"Pause": "pause:2.0@sha256:9ce5316f9752b8347484ab0f6778573af15524124d52b93230b9a0dcc987e73e",
}, map[string]string{
"NvidiaDriverInstaller": "k8s.gcr.io",
"Pause": "k8s.gcr.io",
"NvidiaDriverInstaller": "registry.k8s.io",
"Pause": "registry.k8s.io",
}),
"nvidia-gpu-device-plugin": NewAddon([]*BinAsset{
MustBinAsset(addons.NvidiaGpuDevicePluginAssets,
Expand All @@ -448,7 +448,7 @@ var Addons = map[string]*Addon{
}, false, "nvidia-gpu-device-plugin", "3rd party (Nvidia)", "", "https://minikube.sigs.k8s.io/docs/tutorials/nvidia_gpu/", map[string]string{
"NvidiaDevicePlugin": "nvidia-gpu-device-plugin@sha256:4b036e8844920336fa48f36edeb7d4398f426d6a934ba022848deed2edbf09aa",
}, map[string]string{
"NvidiaDevicePlugin": "k8s.gcr.io",
"NvidiaDevicePlugin": "registry.k8s.io",
}),
"logviewer": NewAddon([]*BinAsset{
MustBinAsset(addons.LogviewerAssets,
Expand Down Expand Up @@ -581,7 +581,7 @@ var Addons = map[string]*Addon{
"GCPAuthWebhook": "k8s-minikube/gcp-auth-webhook:v0.0.13@sha256:08a49cb7a588d81723b7e02c16082c75418b6e0a54cf2e44668bd77f79a41a40",
}, map[string]string{
"GCPAuthWebhook": "gcr.io",
"KubeWebhookCertgen": "k8s.gcr.io",
"KubeWebhookCertgen": "registry.k8s.io",
}),
"volumesnapshots": NewAddon([]*BinAsset{
// make sure the order of apply. `csi-hostpath-snapshotclass` must be the first position, because it depends on `snapshot.storage.k8s.io_volumesnapshotclasses`
Expand Down Expand Up @@ -619,7 +619,7 @@ var Addons = map[string]*Addon{
}, false, "volumesnapshots", "Kubernetes", "", "https://minikube.sigs.k8s.io/docs/tutorials/volume_snapshots_and_csi/", map[string]string{
"SnapshotController": "sig-storage/snapshot-controller:v4.0.0@sha256:00fcc441ea9f72899c25eed61d602272a2a58c5f0014332bdcb5ac24acef08e4",
}, map[string]string{
"SnapshotController": "k8s.gcr.io",
"SnapshotController": "registry.k8s.io",
}),
"csi-hostpath-driver": NewAddon([]*BinAsset{
MustBinAsset(addons.CsiHostpathDriverAssets,
Expand Down Expand Up @@ -698,15 +698,15 @@ var Addons = map[string]*Addon{
"Snapshotter": "sig-storage/csi-snapshotter:v4.0.0@sha256:51f2dfde5bccac7854b3704689506aeecfb793328427b91115ba253a93e60782",
"Provisioner": "sig-storage/csi-provisioner:v2.1.0@sha256:20c828075d1e36f679d6a91e905b0927141eef5e15be0c9a1ca4a6a0ed9313d2",
}, map[string]string{
"Attacher": "k8s.gcr.io",
"HostMonitorAgent": "k8s.gcr.io",
"HostMonitorController": "k8s.gcr.io",
"NodeDriverRegistrar": "k8s.gcr.io",
"HostPathPlugin": "k8s.gcr.io",
"LivenessProbe": "k8s.gcr.io",
"Resizer": "k8s.gcr.io",
"Snapshotter": "k8s.gcr.io",
"Provisioner": "k8s.gcr.io",
"Attacher": "registry.k8s.io",
"HostMonitorAgent": "registry.k8s.io",
"HostMonitorController": "registry.k8s.io",
"NodeDriverRegistrar": "registry.k8s.io",
"HostPathPlugin": "registry.k8s.io",
"LivenessProbe": "registry.k8s.io",
"Resizer": "registry.k8s.io",
"Snapshotter": "registry.k8s.io",
"Provisioner": "registry.k8s.io",
}),
"portainer": NewAddon([]*BinAsset{
MustBinAsset(addons.PortainerAssets,
Expand Down Expand Up @@ -951,8 +951,8 @@ func GenerateTemplateData(addon *Addon, cc *config.ClusterConfig, netInfo Networ
// tl;dr If the user specified a custom image remove the default registry
// Without the line below, if you try to overwrite an image the default registry is still used in the templating
// Example - image name: MetricsScraper, default registry: docker.io, default image: kubernetesui/metrics-scraper
// Passed on addon enable: --images=MetricsScraper=k8s.gcr.io/echoserver:1.4
// Without this line the resulting image would be docker.io/k8s.gcr.io/echoserver:1.4
// Passed on addon enable: --images=MetricsScraper=registry.k8s.io/echoserver:1.4
// Without this line the resulting image would be docker.io/registry.k8s.io/echoserver:1.4
if _, ok := cc.CustomAddonImages[name]; ok {
opts.Registries[name] = ""
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/minikube/bootstrapper/images/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import (
)

const (
// builds a docker v2 repository API call in the format https://k8s.gcr.io/v2/coredns/coredns/tags/list
// builds a docker v2 repository API call in the format https://registry.k8s.io/v2/coredns/coredns/tags/list
tagURLTemplate = "https://%s/v2/%s/tags/list"
)

Expand Down Expand Up @@ -70,7 +70,7 @@ func componentImage(name string, v semver.Version, mirror string) string {
return fmt.Sprintf("%s:v%s", path.Join(kubernetesRepo(mirror, v), name), v)
}

// fixes 13136 by getting the latest image version from the k8s.gcr.io repository instead of hardcoded
// fixes 13136 by getting the latest image version from the registry.k8s.io repository instead of hardcoded
func findLatestTagFromRepository(url string, lastKnownGood string) string {
client := &http.Client{}
errorMsg := fmt.Sprintf("Failed to get latest image version for %s, reverting to version %s.", url, lastKnownGood)
Expand Down
72 changes: 36 additions & 36 deletions pkg/minikube/bootstrapper/images/images_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,49 +33,49 @@ func TestEssentials(t *testing.T) {
images []string
}{
{"v1.18.0", strings.Split(strings.Trim(`
k8s.gcr.io/kube-apiserver:v1.18.0
k8s.gcr.io/kube-controller-manager:v1.18.0
k8s.gcr.io/kube-scheduler:v1.18.0
k8s.gcr.io/kube-proxy:v1.18.0
k8s.gcr.io/pause:3.2
k8s.gcr.io/etcd:3.4.3-0
k8s.gcr.io/coredns:1.6.7
registry.k8s.io/kube-apiserver:v1.18.0
registry.k8s.io/kube-controller-manager:v1.18.0
registry.k8s.io/kube-scheduler:v1.18.0
registry.k8s.io/kube-proxy:v1.18.0
registry.k8s.io/pause:3.2
registry.k8s.io/etcd:3.4.3-0
registry.k8s.io/coredns:1.6.7
`, "\n"), "\n")},
{"v1.19.0", strings.Split(strings.Trim(`
k8s.gcr.io/kube-apiserver:v1.19.0
k8s.gcr.io/kube-controller-manager:v1.19.0
k8s.gcr.io/kube-scheduler:v1.19.0
k8s.gcr.io/kube-proxy:v1.19.0
k8s.gcr.io/pause:3.2
k8s.gcr.io/etcd:3.4.9-1
k8s.gcr.io/coredns:1.7.0
registry.k8s.io/kube-apiserver:v1.19.0
registry.k8s.io/kube-controller-manager:v1.19.0
registry.k8s.io/kube-scheduler:v1.19.0
registry.k8s.io/kube-proxy:v1.19.0
registry.k8s.io/pause:3.2
registry.k8s.io/etcd:3.4.9-1
registry.k8s.io/coredns:1.7.0
`, "\n"), "\n")},
{"v1.20.0", strings.Split(strings.Trim(`
k8s.gcr.io/kube-apiserver:v1.20.0
k8s.gcr.io/kube-controller-manager:v1.20.0
k8s.gcr.io/kube-scheduler:v1.20.0
k8s.gcr.io/kube-proxy:v1.20.0
k8s.gcr.io/pause:3.2
k8s.gcr.io/etcd:3.4.13-0
k8s.gcr.io/coredns:1.7.0
registry.k8s.io/kube-apiserver:v1.20.0
registry.k8s.io/kube-controller-manager:v1.20.0
registry.k8s.io/kube-scheduler:v1.20.0
registry.k8s.io/kube-proxy:v1.20.0
registry.k8s.io/pause:3.2
registry.k8s.io/etcd:3.4.13-0
registry.k8s.io/coredns:1.7.0
`, "\n"), "\n")},
{"v1.21.0", strings.Split(strings.Trim(`
k8s.gcr.io/kube-apiserver:v1.21.0
k8s.gcr.io/kube-controller-manager:v1.21.0
k8s.gcr.io/kube-scheduler:v1.21.0
k8s.gcr.io/kube-proxy:v1.21.0
k8s.gcr.io/pause:3.4.1
k8s.gcr.io/etcd:3.4.13-0
k8s.gcr.io/coredns/coredns:v1.8.0
registry.k8s.io/kube-apiserver:v1.21.0
registry.k8s.io/kube-controller-manager:v1.21.0
registry.k8s.io/kube-scheduler:v1.21.0
registry.k8s.io/kube-proxy:v1.21.0
registry.k8s.io/pause:3.4.1
registry.k8s.io/etcd:3.4.13-0
registry.k8s.io/coredns/coredns:v1.8.0
`, "\n"), "\n")},
{"v1.22.0", strings.Split(strings.Trim(`
k8s.gcr.io/kube-apiserver:v1.22.0
k8s.gcr.io/kube-controller-manager:v1.22.0
k8s.gcr.io/kube-scheduler:v1.22.0
k8s.gcr.io/kube-proxy:v1.22.0
k8s.gcr.io/pause:3.5
k8s.gcr.io/etcd:3.5.0-0
k8s.gcr.io/coredns/coredns:v1.8.4
registry.k8s.io/kube-apiserver:v1.22.0
registry.k8s.io/kube-controller-manager:v1.22.0
registry.k8s.io/kube-scheduler:v1.22.0
registry.k8s.io/kube-proxy:v1.22.0
registry.k8s.io/pause:3.5
registry.k8s.io/etcd:3.5.0-0
registry.k8s.io/coredns/coredns:v1.8.4
`, "\n"), "\n")},
}
for _, tc := range testCases {
Expand All @@ -85,7 +85,7 @@ k8s.gcr.io/coredns/coredns:v1.8.4
t.Fatal(err)
}
want := tc.images
got := essentials("k8s.gcr.io", v)
got := essentials("registry.k8s.io", v)
if diff := cmp.Diff(want, got); diff != "" {
t.Errorf("images mismatch (-want +got):\n%s", diff)
}
Expand Down
56 changes: 28 additions & 28 deletions pkg/minikube/bootstrapper/images/kubeadm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,43 +75,43 @@ func TestKubeadmImages(t *testing.T) {
"mirror.k8s.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
}},
{"v1.24.0", "", false, []string{
"k8s.gcr.io/kube-proxy:v1.24.0",
"k8s.gcr.io/kube-scheduler:v1.24.0",
"k8s.gcr.io/kube-controller-manager:v1.24.0",
"k8s.gcr.io/kube-apiserver:v1.24.0",
"k8s.gcr.io/coredns/coredns:v1.8.6",
"k8s.gcr.io/etcd:3.5.3-0",
"k8s.gcr.io/pause:3.7",
"registry.k8s.io/kube-proxy:v1.24.0",
"registry.k8s.io/kube-scheduler:v1.24.0",
"registry.k8s.io/kube-controller-manager:v1.24.0",
"registry.k8s.io/kube-apiserver:v1.24.0",
"registry.k8s.io/coredns/coredns:v1.8.6",
"registry.k8s.io/etcd:3.5.3-0",
"registry.k8s.io/pause:3.7",
"gcr.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
}},
{"v1.23.0", "", false, []string{
"k8s.gcr.io/kube-proxy:v1.23.0",
"k8s.gcr.io/kube-scheduler:v1.23.0",
"k8s.gcr.io/kube-controller-manager:v1.23.0",
"k8s.gcr.io/kube-apiserver:v1.23.0",
"k8s.gcr.io/coredns/coredns:v1.8.6",
"k8s.gcr.io/etcd:3.5.1-0",
"k8s.gcr.io/pause:3.6",
"registry.k8s.io/kube-proxy:v1.23.0",
"registry.k8s.io/kube-scheduler:v1.23.0",
"registry.k8s.io/kube-controller-manager:v1.23.0",
"registry.k8s.io/kube-apiserver:v1.23.0",
"registry.k8s.io/coredns/coredns:v1.8.6",
"registry.k8s.io/etcd:3.5.1-0",
"registry.k8s.io/pause:3.6",
"gcr.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
}},
{"v1.22.0", "", false, []string{
"k8s.gcr.io/kube-proxy:v1.22.0",
"k8s.gcr.io/kube-scheduler:v1.22.0",
"k8s.gcr.io/kube-controller-manager:v1.22.0",
"k8s.gcr.io/kube-apiserver:v1.22.0",
"k8s.gcr.io/coredns/coredns:v1.8.4",
"k8s.gcr.io/etcd:3.5.0-0",
"k8s.gcr.io/pause:3.5",
"registry.k8s.io/kube-proxy:v1.22.0",
"registry.k8s.io/kube-scheduler:v1.22.0",
"registry.k8s.io/kube-controller-manager:v1.22.0",
"registry.k8s.io/kube-apiserver:v1.22.0",
"registry.k8s.io/coredns/coredns:v1.8.4",
"registry.k8s.io/etcd:3.5.0-0",
"registry.k8s.io/pause:3.5",
"gcr.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
}},
{"v1.16.0", "", false, []string{
"k8s.gcr.io/kube-proxy:v1.16.0",
"k8s.gcr.io/kube-scheduler:v1.16.0",
"k8s.gcr.io/kube-controller-manager:v1.16.0",
"k8s.gcr.io/kube-apiserver:v1.16.0",
"k8s.gcr.io/coredns:1.6.2",
"k8s.gcr.io/etcd:3.3.15-0",
"k8s.gcr.io/pause:3.1",
"registry.k8s.io/kube-proxy:v1.16.0",
"registry.k8s.io/kube-scheduler:v1.16.0",
"registry.k8s.io/kube-controller-manager:v1.16.0",
"registry.k8s.io/kube-apiserver:v1.16.0",
"registry.k8s.io/coredns:1.6.2",
"registry.k8s.io/etcd:3.3.15-0",
"registry.k8s.io/pause:3.1",
"gcr.io/k8s-minikube/storage-provisioner:" + version.GetStorageProvisionerVersion(),
}},
{"v1.11.0", "", true, nil},
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/images/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
)

// OldDefaultKubernetesRepo is the old default Kubernetes repository
const OldDefaultKubernetesRepo = "k8s.gcr.io"
const OldDefaultKubernetesRepo = "registry.k8s.io"

// NewDefaultKubernetesRepo is the new default Kubernetes repository
const NewDefaultKubernetesRepo = "registry.k8s.io"
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/config/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ type ClusterConfig struct {
KubernetesConfig KubernetesConfig
Nodes []Node
Addons map[string]bool
CustomAddonImages map[string]string // Maps image names to the image to use for addons. e.g. Dashboard -> k8s.gcr.io/echoserver:1.4 makes dashboard addon use echoserver for its Dashboard deployment.
CustomAddonImages map[string]string // Maps image names to the image to use for addons. e.g. Dashboard -> registry.k8s.io/echoserver:1.4 makes dashboard addon use echoserver for its Dashboard deployment.
CustomAddonRegistries map[string]string // Maps image names to the registry to use for addons. See CustomAddonImages for example.
VerifyComponents map[string]bool // map of components to verify and wait for after start.
StartHostTimeout time.Duration
Expand Down
4 changes: 2 additions & 2 deletions pkg/minikube/image/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ func DeleteFromCacheDir(images []string) error {
// SaveToDir will cache images on the host
//
// The cache directory currently caches images using the imagename_tag
// For example, k8s.gcr.io/kube-addon-manager:v6.5 would be
// stored at $CACHE_DIR/k8s.gcr.io/kube-addon-manager_v6.5
// For example, registry.k8s.io/kube-addon-manager:v6.5 would be
// stored at $CACHE_DIR/registry.k8s.io/kube-addon-manager_v6.5
func SaveToDir(images []string, cacheDir string, overwrite bool) error {
var g errgroup.Group
for _, image := range images {
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/reason/match_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ VBoxManage.exe: error: Details: code E_FAIL (0x80004005), component MachineWrap,
{4913, "linux", "PR_KVM_CREATE_BUSY", `Unable to start VM: create: Error creating machine: Error in driver during machine creation: error creating VM: virError(Code=1, Domain=10, Message='internal error: process exited while connecting to monitor: ioctl(KVM_CREATE_VM) failed: 16 Device or resource busy`},
{5950, "linux", "PR_KVM_ISO_PERMISSION", `Retriable failure: create: Error creating machine: Error in driver during machine creation: error creating VM: virError(Code=1, Domain=10, Message='internal error: qemu unexpectedly closed the monitor: 2019-11-19T16:08:16.757609Z qemu-kvm: -drive file=/home/lnicotra/.minikube/machines/minikube/boot2docker.iso,format=raw,if=none,id=drive-scsi0-0-0-2,readonly=on: could not open disk image /home/lnicotra/.minikube/machines/minikube/boot2docker.iso: Could not open '/home/lnicotra/.minikube/machines/minikube/boot2docker.iso': Permission denied'`},
{5836, "", "SVC_OPEN_NOT_FOUND", `Error opening service: Service kubernetes-bootcamp was not found in "default" namespace. You may select another namespace by using 'minikube service kubernetes-bootcamp -n : Temporary Error: Error getting service kubernetes-bootcamp: services "kubernetes-bootcamp" not found`},
{3898, "", "INET_PULL_TIMEOUT", `[ERROR ImagePull]: failed to pull image k8s.gcr.io/kube-controller-manager:v1.17.0: output: Error response from daemon: Get https://k8s.gcr.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)`},
{3898, "", "INET_PULL_TIMEOUT", `[ERROR ImagePull]: failed to pull image registry.k8s.io/kube-controller-manager:v1.17.0: output: Error response from daemon: Get https://registry.k8s.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)`},
{6079, "darwin", "PR_HYPERKIT_CRASHED", `Error creating machine: Error in driver during machine creation: hyperkit crashed! command line:`},
{5636, "linux", "INET_DEFAULT_ROUTE", `Unable to get VM IP address: unable to select an IP from default routes.`},
{6087, "", "GUEST_DOES_NOT_EXIST", `Error getting host status: state: machine does not exist`},
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/contrib/tests.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ Steps:
asserts basic "service" command functionality

Steps:
- Create a new `k8s.gcr.io/echoserver` deployment
- Create a new `registry.k8s.io/echoserver` deployment
- Run `minikube service list` to make sure the newly created service is correctly listed in the output
- Run `minikube service` with `--https --url` to make sure the HTTPS endpoint URL of the service is printed
- Run `minikube service` with `--url --format={{.IP}}` to make sure the IP address of the service is printed
Expand All @@ -303,7 +303,7 @@ Steps:
#### validateServiceCmdConnect

Steps:
- Create a new `k8s.gcr.io/echoserver` deployment
- Create a new `registry.k8s.io/echoserver` deployment
- Run `minikube service` with a regular `--url` to make sure the HTTP endpoint URL of the service is printed
- Make sure we can hit the endpoint URL with an HTTP GET request

Expand Down
Loading

0 comments on commit eb0cbbb

Please sign in to comment.