Skip to content

Commit

Permalink
Update pkg/minikube/node/start.go
Browse files Browse the repository at this point in the history
Co-authored-by: Steven Powell <[email protected]>
  • Loading branch information
ComradeProgrammer and spowelljr authored Jun 30, 2024
1 parent bfc9828 commit 779568b
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions pkg/minikube/node/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -873,14 +873,11 @@ func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
// now we shall also try whether this registry is reachable outside the machine
// so that we can tell in the logs that if the user's computer had any network issue or could it be related to a network module config change in minikbue ISO
if err := cmd.Run(); err != nil {
outside = false
}
if !outside {
// both inside and outside failed
out.WarningT("This {{.type}} is also having trouble accessing https://{{.repository}} both inside and outside the minikube ", out.V{"repository": imageRepository, "type": driver.MachineType(driverName)})
out.WarningT("Failing to connect to {{.curlTarget}} from both inside the minikube {{.type}} and host machine", out.V{"curlTarget": curlTarget, "type": driver.MachineType(driverName)})

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube

undefined: curlTarget

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube

undefined: curlTarget

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube_test_binaries

undefined: curlTarget

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / lint

undefined: curlTarget

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / lint

undefined: curlTarget

Check failure on line 877 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / unit_test

undefined: curlTarget
} else {
// only inside the minikube failed
out.WarningT("This {{.type}} is having trouble accessing https://{{.repository}} only inside the minikube", out.V{"repository": imageRepository, "type": driver.MachineType(driverName)})
out.WarningT("Failing to connect to {{.curlTarget}} from inside the minikube {{.type}}", out.V{"curlTarget": curlTarget, "type": driver.MachineType(driverName)})

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube

undefined: curlTarget

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube

undefined: curlTarget

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / build_minikube_test_binaries

undefined: curlTarget

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / lint

undefined: curlTarget (typecheck)

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / lint

undefined: curlTarget) (typecheck)

Check failure on line 880 in pkg/minikube/node/start.go

View workflow job for this annotation

GitHub Actions / unit_test

undefined: curlTarget
}
out.ErrT(style.Tip, "To pull new external images, you may need to configure a proxy: https://minikube.sigs.k8s.io/docs/reference/networking/proxy/")
}
Expand Down

0 comments on commit 779568b

Please sign in to comment.