Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube-addon-manager image to v9.1.2 #98974

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Update kube-addon-manager image to v9.1.2 #98974

merged 1 commit into from
Feb 16, 2021
+4 −4

Conversation

dekkagaijin
Copy link
Contributor

Updates the addon-manager to use the image with the fix implemented in #93762

/kind bug

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2021
@k8s-ci-robot
Copy link
Contributor

@dekkagaijin: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2021
@dekkagaijin
Copy link
Contributor Author

/assign liggitt

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2021
@dekkagaijin
Copy link
Contributor Author

/cc @MrHohn @spencer-p

@k8s-ci-robot
Copy link
Contributor

@dekkagaijin: GitHub didn't allow me to request PR reviews from the following users: spencer-p.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @MrHohn @spencer-p

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MrHohn
MrHohn approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the gce change.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkagaijin, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021
liggitt
liggitt reviewed Feb 10, 2021
View reviewed changes
test/kubemark/resources/manifests/kube-addon-manager.yaml Outdated
@@ -9,7 +9,7 @@ spec:
hostNetwork: true
containers:
- name: kube-addon-manager
image: {{kube_docker_registry}}/kube-addon-manager:v9.1.1
image: {{kube_docker_registry}}/kube-addon-manager:v9.1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want 9.1.2 or the current 9.1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 9.1.2 is the latest in prod: https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-addon-manager/images.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. uh... ok... cc @spencer-p re: #96969 (comment)

@dekkagaijin
Copy link
Contributor Author

/retest

1 similar comment
@dekkagaijin
Copy link
Contributor Author

/retest

@dekkagaijin
Copy link
Contributor Author

/retest

@dekkagaijin
Copy link
Contributor Author

harharhar
/retest

@MrHohn
Copy link
Member

MrHohn commented Feb 11, 2021

Saw this error message from kubelet (for this run):

E0210 22:15:32.585908    1774 pod_workers.go:191] Error syncing pod 370ce228363689eac44ec00d11e0ad57 ("kube-addon-manager-e2e-98974-95a39-master_kube-system(370ce228363689eac44ec00d11e0ad57)"), skipping: failed to "StartContainer" for "kube-addon-manager" with ImagePullBackOff: "Back-off pulling image \"k8s.gcr.io/kube-addon-manager:v9.1.2\""

So I realized we might need to adjust the GCR repo as well. Let me find the updated one quickly.

@MrHohn
Copy link
Member

MrHohn commented Feb 11, 2021

Looks like it is updated to be k8s.gcr.io/addon-manager/kube-addon-manager:v9.1.2 now.

@dekkagaijin Mind updating to use that?

@dekkagaijin
Copy link
Contributor Author

@MrHohn good catch

@dekkagaijin
Copy link
Contributor Author

@liggitt all green, PTAL

@liggitt
Copy link
Member

liggitt commented Feb 11, 2021

/cc @zmerlynn

will defer to @zmerlynn for lgtm

@jackfrancis jackfrancis mentioned this pull request Feb 12, 2021
Merged
8 tasks
@liggitt liggitt mentioned this pull request Feb 15, 2021
Merged
@liggitt liggitt assigned zmerlynn and unassigned liggitt Feb 16, 2021
@zmerlynn
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 111d82f into kubernetes:master Feb 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@MrHohn MrHohn MrHohn approved these changes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@dekkagaijin @k8s-ci-robot @MrHohn @liggitt @zmerlynn