Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging/src/k8s.io/apiserver/pkg/admission: migrate to structured logs #98138

Merged
merged 1 commit into from
Jan 27, 2021
Merged

staging/src/k8s.io/apiserver/pkg/admission: migrate to structured logs #98138

merged 1 commit into from
Jan 27, 2021

Conversation

lala123912
Copy link
Contributor

@lala123912 lala123912 commented Jan 18, 2021 •
edited by liggitt
Loading

Migrate to structured logs

File modified:
staging/src/k8s.io/apiserver/pkg/admission

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Ref:

keps/sig-instrumentation/1602-structured-logging
Structured Logging migration instructions

Which issue(s) this PR fixes:
Ref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2021
@k8s-ci-robot
Copy link
Contributor

@lala123912: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2021
@lala123912
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot requested review from ncdc and sttts January 18, 2021 09:28
@lala123912
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2021
@lala123912 lala123912 force-pushed the log_format_admission branch 2 times, most recently from 2aef029 to e6ebd4f Compare January 18, 2021 12:14
@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 18, 2021
@sttts sttts added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 18, 2021
@lala123912
Copy link
Contributor Author

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t January 19, 2021 01:23
@ncdc
Copy link
Member

ncdc commented Jan 20, 2021

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from ncdc January 20, 2021 19:17
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 21, 2021
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Jan 21, 2021
@lala123912
Copy link
Contributor Author

/uncc @wojtek-t

@k8s-ci-robot k8s-ci-robot removed the request for review from wojtek-t January 22, 2021 06:47
@lala123912
Copy link
Contributor Author

/cc @serathius

@serathius
Copy link
Contributor

Overall commend about fixing messages we should use active voice.

From https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#remove-string-formatting-from-log-message

* Use active voice. Use complete sentences when there is an acting subject ("A could not do B") or omit the subject if the subject would be the program itself ("Could not do B").

Could you look through messages, propose an actor and update them to use active voice? C

@lala123912 lala123912 force-pushed the log_format_admission branch 3 times, most recently from 2818fef to 436a64f Compare January 26, 2021 01:47
@lala123912 lala123912 force-pushed the log_format_admission branch from 436a64f to 2dc8cad Compare January 26, 2021 08:36
@serathius
Copy link
Contributor

/lgtm
/assign @sttts

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@sttts
Copy link
Contributor

sttts commented Jan 27, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lala123912, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit e0bba10 into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021
@qmloong qmloong mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@sttts sttts sttts left review comments

Assignees

@sttts sttts

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@lala123912 @k8s-ci-robot @ncdc @serathius @sttts