Release reserved GCE IP address after ensure completes, irrespective of outcome. #97740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior was to release the ip only upon success, but it should be released on failure as well. Otherwise, an IP address will be unnecessarily consumed due to an in-error service.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/cloudprovider
sig/cloud-provider
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
lgtm
|
/assign @liggitt @andrewsykim |
|
/approve |
|
/approve cancel deferring to cloud-provider approvers |
|
/unassign |
|
/approve Should this have release notes? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Since this is a bug fix, I had not added releases notes. Updated the PR now. |
This was referenced Jan 6, 2021
Merged
Merged
Merged
Merged
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 8, 2021
…40-upstream-release-1.20 Automated cherry pick of #97740: Release reserved GCE IP address after ensure completes.
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 8, 2021
…40-upstream-release-1.19 Automated cherry pick of #97740: Release reserved GCE IP address after ensure completes.
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 8, 2021
…40-upstream-release-1.17 Automated cherry pick of #97740: Release reserved GCE IP address after ensure completes.
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 8, 2021
…40-upstream-release-1.18 Automated cherry pick of #97740: Release reserved GCE IP address after ensure completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior was to release the ip only upon success, but it should be released
on failure as well. Otherwise, an IP address will be unnecessarily consumed due to an
in-error service.
What type of PR is this?
What this PR does / why we need it:
Prior to this change, the controller behavior was to release the ip only upon success, but it should be released
on failure as well. Otherwise, an IP address will be unnecessarily consumed due to an
in-error service.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: