Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: warn when creating roles with custom verbs #92492

Merged
merged 1 commit into from
Sep 22, 2020
Merged

kubectl: warn when creating roles with custom verbs #92492

merged 1 commit into from
Sep 22, 2020
+9 −6

Conversation

eddiezane
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR replaces errors with warnings when creating Roles and ClusterRoles with custom verbs via kubectl create.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#876

Special notes for your reviewer:

This fix came from a discussion on Slack.

Does this PR introduce a user-facing change?:

Warn instead of fail when creating Roles and ClusterRoles with custom verbs via kubectl

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@eddiezane
Warn when creating roles with custom verbs kubectl
c9420cd 
Remove errors when using custom verbs

Signed-off-by: Eddie Zaneski <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2020
@eddiezane
Copy link
Member Author

/sig cli
/assign @brianpursley
/area kubectl
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2020
@eddiezane eddiezane changed the title kubectl: warn when creating roles with custom verbs kubectl kubectl: warn when creating roles with custom verbs Jun 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from dixudx and zhouya0 June 24, 2020 22:38
@brianpursley
Copy link
Member

/lgtm
/assign @seans3

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2020
@zhouya0
Copy link
Contributor

zhouya0 commented Jun 25, 2020

/lgtm

dixudx
dixudx approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eddiezane
Copy link
Member Author

/retest

seans3
seans3 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5c6d853 into kubernetes:master Sep 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 22, 2020
@eddiezane eddiezane deleted the ez/kubectl-876-warn-on-verb-validation branch September 23, 2020 03:27
@github-actions github-actions bot mentioned this pull request Sep 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouya0 zhouya0 zhouya0 approved these changes

@seans3 seans3 seans3 approved these changes

@dixudx dixudx dixudx approved these changes

Assignees

@brianpursley brianpursley

@dixudx dixudx

@seans3 seans3

@zhouya0 zhouya0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Verb validation when creating role not in line with API
6 participants
@eddiezane @brianpursley @zhouya0 @k8s-ci-robot @dixudx @seans3