Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17] Update CNI to v0.8.6 #91386

Merged
merged 4 commits into from
May 27, 2020
Merged

[1.17] Update CNI to v0.8.6 #91386

merged 4 commits into from
May 27, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 24, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup
/area dependency release-eng
/sig network release

What this PR does / why we need it:

Update CNI to v0.8.6

cc: @kubernetes/release-engineering @kubernetes/sig-network-misc
/assign @BenTheElder @yujuhong @tallclair
ref: kubernetes/release#1309

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Update CNI to v0.8.6
- build: Use [email protected] image

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 24, 2020
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 24, 2020
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 24, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and fejta May 24, 2020 00:55
@k8s-ci-robot k8s-ci-robot added area/test sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2020
@justaugustus justaugustus mentioned this pull request May 24, 2020
Merged
saschagrunert
saschagrunert approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
cpanato
cpanato approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cblecker
Copy link
Member

/hold
Requesting details on why this is being picked back

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@cblecker
Copy link
Member

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 27, 2020
@justaugustus
Copy link
Member Author

Image has been promoted: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-k8sio-cip/1265499696156119040
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@justaugustus
Copy link
Member Author

/pull-kubernetes-bazel-build
/pull-kubernetes-bazel-test

@justaugustus
build: Use [email protected] image
2091944 
Signed-off-by: Stephen Augustus <[email protected]>
liggitt
liggitt reviewed May 27, 2020
View reviewed changes
cluster/gce/util.sh
Comment on lines +1139 to +1140
CNI_STORAGE_URL_BASE: $(yaml-quote ${CNI_STORAGE_URL_BASE:-})
CNI_TAR_PREFIX: $(yaml-quote ${CNI_TAR_PREFIX:-})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowei to review cluster CNI changes

liggitt
liggitt reviewed May 27, 2020
View reviewed changes
cluster/gce/config-default.sh
Comment on lines +304 to +306
CNI_SHA1=${CNI_SHA1:-}
CNI_TAR_PREFIX=${CNI_TAR_PREFIX:-cni-plugins-linux-amd64-}
CNI_STORAGE_URL_BASE=${CNI_STORAGE_URL_BASE:-https://storage.googleapis.com/k8s-artifacts-cni/release}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowei to review

@liggitt
Copy link
Member

liggitt commented May 27, 2020

bazel and build bits look reasonable, tagged the network team to review the cluster CNI changes

@bowei
Copy link
Member

bowei commented May 27, 2020

CNI changes

/approve

@liggitt
Copy link
Member

liggitt commented May 27, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cblecker, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@liggitt
Copy link
Member

liggitt commented May 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4c6c334 into kubernetes:release-1.17 May 27, 2020
@joelsmith joelsmith mentioned this pull request Jun 1, 2020
Closed
@justaugustus justaugustus mentioned this pull request Jun 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@dims dims Awaiting requested review from dims

@fejta fejta Awaiting requested review from fejta

Assignees

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@liggitt liggitt

@cpanato cpanato

@yujuhong yujuhong

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.