Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #89539: Fixes problem where kubectl apply stops after first error #89607

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Automated cherry pick of #89539: Fixes problem where kubectl apply stops after first error #89607

merged 2 commits into from
Mar 30, 2020

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Mar 28, 2020 •
edited
Loading

Cherry pick of #89539 on release-1.18.

#89539: Fixes P0 kubectl apply bug.

P0 kubectl apply bug: kubernetes/kubectl#845

For details on the cherry pick process, see the cherry pick requests page.

kubectl: Fixes bug by aggregating 'apply' errors instead of failing after first error

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 28, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl labels Mar 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from adohe-zz and dixudx March 28, 2020 00:20
@k8s-ci-robot k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 28, 2020
@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 28, 2020
@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2020
@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 28, 2020
@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/retest

@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/assign @pwittrock

@pwittrock
Copy link
Member

/lgtm

@pwittrock
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwittrock, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3
Copy link
Contributor Author

seans3 commented Mar 28, 2020

/cc @kubernetes/patch-release-team

@seans3
Copy link
Contributor Author

seans3 commented Mar 29, 2020

/cc @justaugustus
/cc @tpepper
/cc @dougm

@idealhack idealhack added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 30, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit bf23e93 into kubernetes:release-1.18 Mar 30, 2020
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#89607 from seans3/automated-cherry-pick…
81ea774 
…-of-#89539-upstream-release-1.18

Automated cherry pick of kubernetes#89539: Fixes problem where kubectl apply stops after first error

Kubernetes-commit: bf23e93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@dixudx dixudx Awaiting requested review from dixudx

@dougm dougm Awaiting requested review from dougm

@justaugustus justaugustus Awaiting requested review from justaugustus

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@seans3 @pwittrock @k8s-ci-robot @fejta-bot @idealhack