Lengthening initial backoff time for EndpointSlice controller #89438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
size/M
wojtek-t
reviewed
Mar 24, 2020
liggitt
reviewed
Mar 24, 2020
robscott
force-pushed
the
endpointslice-controller-error-backoff
branch
3 times, most recently
from
84c8359 to
7ae3e16
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
k8s-ci-robot
added
the
do-not-merge/hold
The EndpointSlice controller has the potential to manage a large number of resources that are updated frequently. Without proper backoffs in place, there is potential for it to unnecessarily overload the API Server with requests. This makes two significant changes: Increasing the base backoff from 5ms to 1s and making all syncs triggered by EndpointSlice changes delayed by at least 1 second to enable batching.
robscott
force-pushed
the
endpointslice-controller-error-backoff
branch
from
7ae3e16 to
94e5537
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The EndpointSlice controller has the potential to manage a large number of resources that are updated frequently. Without proper backoffs in place, there is potential for it to unnecessarily overload the API Server with requests. This makes two significant changes:
Special notes for your reviewer:
I've tested this with several e2e clusters with 2 failure scenarios:
discovery.k8s.io/v1beta1API Group on the API ServercreateEndpointSlices from EndpointSlice controller ClusterRoleIn both cases the increased thresholds for exponential backoff seemed to be helpful. Additionally, the backoff value was quickly reset when these conditions were removed and successful syncs resumed.
For reference, here are the base backoffs I've seen for other controllers that have custom values (defaults are 5ms and 1000s):
Does this PR introduce a user-facing change?:
/sig network
/priority important-soon
/cc @wojtek-t
/assign @freehan @liggitt