Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: clarify 1.17 upgrade requirements #87090

Merged
merged 2 commits into from
Jan 31, 2020
Merged

changelog: clarify 1.17 upgrade requirements #87090

merged 2 commits into from
Jan 31, 2020

Conversation

bhcleek
Copy link
Contributor

@bhcleek bhcleek commented Jan 10, 2020

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Clarify the 1.17 upgrade requirements for storage so that it doesn't
ready as if an entire cluster has to be drained before any node can be
upgraded.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@bhcleek
changelog: clarify 1.17 upgrade requirements
a1f9989 
Clarify the 1.17 upgrade requirements for storage so that it doesn't
ready as if an entire cluster has to be drained before any node can be
upgraded.
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bhcleek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bhcleek
Copy link
Contributor Author

bhcleek commented Jan 10, 2020

/assign @saschagrunert

saschagrunert
saschagrunert approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@saschagrunert
Copy link
Member

saschagrunert commented Jan 10, 2020 •
edited
Loading

/ok-to-test
/sig docs

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2020
@saschagrunert
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 10, 2020
@saschagrunert
Copy link
Member

saschagrunert commented Jan 10, 2020 •
edited
Loading

Seeking for approval by @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2020
msau42
msau42 reviewed Jan 10, 2020
View reviewed changes
CHANGELOG-1.17.md Outdated
@@ -150,7 +150,7 @@ Prior to 1.17 and for existing nodes created by `kubeadm init` where kubelet cli
- Kubeadm: when adding extra apiserver authorization-modes, the defaults `Node,RBAC` are no longer prepended in the resulting static Pod manifests and a full override is allowed. ([#82616](https://github.com/kubernetes/kubernetes/pull/82616), [@ghouscht](https://github.com/ghouscht))

#### Storage
- All nodes need to be drained before upgrading Kubernetes cluster, because paths used for block volumes are changed in this release, so on-line upgrade of nodes aren't allowed. ([#74026](https://github.com/kubernetes/kubernetes/pull/74026), [@mkimuram](https://github.com/mkimuram))
- When CSI is used for block volumes and workers are on-line upgraded (i.e., kubelet is restarted only), masters must be upgraded before workers and each worker must be drained before it can be upgraded. ([#74026](https://github.com/kubernetes/kubernetes/pull/74026), [@mkimuram](https://github.com/mkimuram))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified to:

"A node that uses a CSI raw block volume needs to be drained before kubelet can be upgraded to 1.17"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@bhcleek bhcleek mentioned this pull request Jan 10, 2020
Merged
@msau42
Copy link
Member

msau42 commented Jan 11, 2020

/lgtm

Should we cherry pick this to release-1.17 branch as well?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2020
@MorrisLaw
Copy link
Member

Flaky tests? 🤔

hey @alejandrox1 👋 , what do we need to do to get this in?

@justaugustus
Copy link
Member

/lgtm
/approve
/assign @liggitt
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 30, 2020
@justaugustus
Copy link
Member

/retest

@liggitt
Copy link
Member

liggitt commented Jan 30, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bhcleek, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
This was referenced Jan 30, 2020
Closed
Closed
Merged
@MorrisLaw
Copy link
Member

/retest

@saschagrunert
Copy link
Member

@MorrisLaw do you want to update the website as well or should I take care of that?

@MorrisLaw
Copy link
Member

MorrisLaw commented Jan 30, 2020 •
edited
Loading

Either or is fine. I don't mind doing it, I just haven't updated the website before. Is it just making a PR with the new verbiage, to the project that website is in @saschagrunert ?

@MorrisLaw MorrisLaw mentioned this pull request Jan 30, 2020
Closed
@saschagrunert
Copy link
Member

Either or is fine. I don't mind doing it, I just haven't updated the website before. Is it just making a PR with the new verbiage, to the project that website is in @saschagrunert ?

Yes, it’s just updating the markdown release notes in https://github.com/kubernetes/website 🙂

@MorrisLaw
Copy link
Member

Awesome! Should I wait until this is merged or make the PR and note that we should merge pending these changes? @saschagrunert

@saschagrunert
Copy link
Member

Awesome! Should I wait until this is merged or make the PR and note that we should merge pending these changes? @saschagrunert

I think both would be okay since this PR is already on its way into the master :)

@MorrisLaw MorrisLaw mentioned this pull request Jan 30, 2020
Merged
@bhcleek
Copy link
Contributor Author

bhcleek commented Jan 30, 2020

I thought that kubernetes-sigs/release-notes#137 was the website update based on https://kubernetes.slack.com/archives/C2C40FMNF/p1578682428029300?thread_ts=1578677838.025500&cid=C2C40FMNF

@MorrisLaw
Copy link
Member

MorrisLaw commented Jan 30, 2020 •
edited
Loading

I thought that kubernetes-sigs/release-notes#137 was the website update based on https://kubernetes.slack.com/archives/C2C40FMNF/p1578682428029300?thread_ts=1578677838.025500&cid=C2C40FMNF

TLDR; one updates https://relnotes.k8s.io and the other updates https://kubernetes.io

Good question @bhcleek , I wasn't sure about this when you brought this up, but looking through the two projects and based on the PRs it looks like:

The PR I did: kubernetes/website, points to https://kubernetes.io/docs/setup/release/notes/#storage-1.
Your PR: kubernetes-sigs/release-notes, points to somewhere in https://relnotes.k8s.io/?releaseVersions=1.17.0&sigs=storage (top of the list)

Is this correct @saschagrunert ?

@k8s-ci-robot k8s-ci-robot merged commit 7f7fe7c into kubernetes:master Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 31, 2020
@saschagrunert
Copy link
Member

Yep you’re right @MorrisLaw :)

k8s-ci-robot added a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #87700 from MorrisLaw/automated-cherry-pick-of-#87…
c364d12 
…090-upstream-release-1.17

Automated cherry pick of #87090: changelog: clarify 1.17 upgrade requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@liggitt liggitt

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
7 participants
@bhcleek @k8s-ci-robot @saschagrunert @msau42 @MorrisLaw @justaugustus @liggitt