Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated CSI RBAC roles #84282

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Remove deprecated CSI RBAC roles #84282

merged 1 commit into from
Oct 25, 2019
+0 −139

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Oct 24, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR removes deprecated built-in CSI RBAC roles, as #78739 mentioned.

Which issue(s) this PR fixes:
Fixes #78739

The built-in system:csi-external-provisioner and system:csi-external-attacher cluster roles are removed as of 1.17 release

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and ncdc October 24, 2019 08:31
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2019
@yutedz yutedz force-pushed the rm-csi-rbac-roles branch from 50d45df to 13596e5 Compare October 24, 2019 12:33
@ncdc ncdc removed their request for review October 24, 2019 12:39
@tedyu
Copy link
Contributor Author

tedyu commented Oct 24, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Oct 24, 2019

cc @verult

@tedyu
Copy link
Contributor Author

tedyu commented Oct 24, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 24, 2019
@verult
Copy link
Contributor

verult commented Oct 24, 2019

/sig storage
/cc @jsafrane @msau42

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Oct 24, 2019
@msau42
Copy link
Member

msau42 commented Oct 25, 2019

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@liggitt
Copy link
Member

liggitt commented Oct 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit a3560d3 into kubernetes:master Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 25, 2019
hswong3i added a commit to pantarei/ansible-role-kubernetes_cephfs_provisioner that referenced this pull request Dec 20, 2019
@hswong3i
https://github.com/kubernetes/kubernetes/pull/84282
800ae6d
hswong3i added a commit to pantarei/ansible-role-kubernetes_cephfs_provisioner that referenced this pull request Dec 20, 2019
@hswong3i
Revert "kubernetes/kubernetes#84282"
5551092 
This reverts commit 800ae6d.
@pacoxu pacoxu mentioned this pull request May 23, 2023
Closed
@carlory carlory mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@liggitt liggitt

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Remove deprecated built-in CSI RBAC roles in 1.17
6 participants
@tedyu @verult @msau42 @liggitt @k8s-ci-robot @yutedz