Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ephemeral inline CSI volumes as beta #82004

Merged
merged 2 commits into from
Aug 29, 2019
Merged

ephemeral inline CSI volumes as beta #82004

merged 2 commits into from
Aug 29, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Aug 27, 2019 •
edited
Loading

What type of PR is this?
/kind api-change

What this PR does / why we need it:

SIG-Storage wants to move this feature to beta in Kubernetes 1.16 to make it more widely available.

Which issue(s) this PR fixes:

Related-to: kubernetes/enhancements#596

Special notes for your reviewer:

Depends on #82012 (to fix a test failure) and #81960 (to increase test coverage).

Does this PR introduce a user-facing change?:

CSI ephemeral inline volume support is beta, i.e. the CSIInlineVolume feature gate is enabled by default

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190122-csi-inline-volumes.md
- [Usage]: https://kubernetes.io/docs/concepts/storage/volumes/#csi-ephemeral-volumes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2019
@pohly pohly mentioned this pull request Aug 27, 2019
Closed
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@msau42
Copy link
Member

msau42 commented Aug 27, 2019

/assign

@pohly
Copy link
Contributor Author

pohly commented Aug 27, 2019

@msau42: some of the existing pkg/volumes/csi were based on the assumption that the CSIInlineVolume feature is off and now fail. Two options:

  • temporarily disable the feature at the start of those tests, similar to how it is enabled temporarily in others while the feature is in alpha
  • remove the "with/without CSIInlineVolume" distinction entirely and always assume that it is enabled

I prefer the first option myself because it gives us better overall test coverage and is less intrusive. Any thoughts?

@msau42
Copy link
Member

msau42 commented Aug 27, 2019

Yes, first option sounds good

@pohly
Copy link
Contributor Author

pohly commented Aug 27, 2019

I was waiting for #81960 to merge before updating this PR, but no luck with that so far. Perhaps tomorrow.

pohly added 2 commits August 28, 2019 05:32
@pohly
storage: make tests independent of CSIInlineVolume default
599a9fa 
Some tests assumed instead of ensuring that the CSIInlineVolume
feature is disabled.
@pohly
storage: make CSIInlineVolume a beta feature
482a900 
The feature is complete and supported by an increasing number of CSI
drivers, but before it can be really used, it should be moved out of
alpha into beta.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 28, 2019
@pohly
Copy link
Contributor Author

pohly commented Aug 28, 2019

I propose that we move forward with reviewing this PR on its own. To simplify that, I removed changes that will be merged separately (#82012, #81960). Before we can merge this one, those need to be in.

Round-tripping is expected to fail and must be retested once PR #82012 is merged.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@msau42
Copy link
Member

msau42 commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@msau42
Copy link
Member

msau42 commented Aug 28, 2019

/assign @smarterclayton

@msau42
Copy link
Member

msau42 commented Aug 28, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 28, 2019
@smarterclayton
Copy link
Contributor

/retest

@smarterclayton
Copy link
Contributor

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@pohly
Copy link
Contributor Author

pohly commented Aug 28, 2019

Thanks guys! Now we need to wait for #82012 to land in master, otherwise testing will not pass.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Aug 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit cd9519f into kubernetes:master Aug 29, 2019
@pohly pohly mentioned this pull request Aug 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@smarterclayton smarterclayton

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @fejta-bot @msau42 @smarterclayton @k8s-ci-robot @liggitt