Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct kubectl cp argument order #79845

Merged
merged 1 commit into from
Jul 5, 2019
Merged

correct kubectl cp argument order #79845

merged 1 commit into from
Jul 5, 2019

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Jul 5, 2019

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The argument order of an example is wrong.
https://kubectl.docs.kubernetes.io/pages/container_debugging/copying_container_files.html

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @oke-py. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from deads2k and rootfs July 5, 2019 15:15
@oke-py
Copy link
Contributor Author

oke-py commented Jul 5, 2019

/assign @apelisse

@apelisse
Copy link
Member

apelisse commented Jul 5, 2019

/ok-to-test
/approve
/lgtm

Good catch!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, oke-py

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2019
@apelisse
Copy link
Member

apelisse commented Jul 5, 2019

For next time, I would suggest that you give a little more context on why it is wrong :-)

@oke-py
Copy link
Contributor Author

oke-py commented Jul 5, 2019

ok, thanks!

odinuge
odinuge reviewed Jul 5, 2019
View reviewed changes
staging/src/k8s.io/kubectl/docs/book/pages/container_debugging/copying_container_files.md
@@ -44,7 +44,7 @@ Copy a remote file from a Pod to a local file.
{% sample lang="yaml" %}

```bash
kubectl cp /tmp/foo <some-pod>:/tmp/bar
kubectl cp <some-pod>:/tmp/foo /tmp/bar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref. #79764 this will not work (and I can confirm), since the path part of the pod-spec starts with a leading /. What about just using <some-pod>:foo instead?

cc @apelisse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But still a good catch @oke-py ! 😄

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a warning of tar comand. Successful replication regardless of whether absolute paths are used or not.But I just suggest to remove the wrong message,which can be misleading.Modifying documents is another solution.

@odinuge
Copy link
Member

odinuge commented Jul 5, 2019

/hold

see #79845 (comment)

Feel free to unhold if everything is ok 😄

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2019
@odinuge
Copy link
Member

odinuge commented Jul 5, 2019

Looks like the files are copied, but that it is just a warning. LGTM

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 00cf865 into kubernetes:master Jul 5, 2019
@oke-py oke-py deleted the fix-args branch July 5, 2019 16:41
@oke-py oke-py mentioned this pull request Jul 8, 2019
Closed
6 tasks
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79845 from oke-py/fix-args
400ac46 
correct kubectl cp argument order

Kubernetes-commit: 00cf865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampnick lampnick lampnick left review comments

@odinuge odinuge odinuge left review comments

@deads2k deads2k Awaiting requested review from deads2k

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oke-py @k8s-ci-robot @apelisse @odinuge @lampnick