Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dangling volume as uncertain #78595

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Add dangling volume as uncertain #78595

merged 1 commit into from
Jun 6, 2019

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented May 31, 2019 •
edited
Loading

Adds dangling volumes to old nodes as uncertain, so as they can be detached and cleaned up by attach/detach controller.

Dangling volumes also aren't reported to node's status and hence can't be used by pods.

Fixes #77949

Fix issue with kubelet waiting on invalid devicepath on AWS

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 31, 2019
@gnufied
Copy link
Member Author

gnufied commented May 31, 2019

/sig storage
/assign @jingxu97

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 31, 2019
@gnufied
Copy link
Member Author

gnufied commented May 31, 2019

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2019
@jsafrane
Copy link
Member

jsafrane commented Jun 3, 2019 •
edited
Loading

lgtm-ish, but I don't know all the possible consequences, I'd prefer @jingxu97 to review properly.

@jingxu97
Copy link
Contributor

jingxu97 commented Jun 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2019
@gnufied
Copy link
Member Author

gnufied commented Jun 5, 2019

/kind bug

@saad-ali saad-ali removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 5, 2019
@saad-ali
Copy link
Member

saad-ali commented Jun 5, 2019

/milestone v1.15
Bug fix
/hold
To allow @gnufied to address my feedback

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 5, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2019
@gnufied
Copy link
Member Author

gnufied commented Jun 6, 2019

addressed the comment.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2019
@dims
Copy link
Member

dims commented Jun 6, 2019

re-applying lgtm from @jingxu97

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 333081e into kubernetes:master Jun 6, 2019
@gnufied gnufied mentioned this pull request Aug 13, 2019
Merged
@andyzhangx andyzhangx mentioned this pull request Aug 15, 2020
Closed
@andyzhangx andyzhangx mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali left review comments

@rootfs rootfs Awaiting requested review from rootfs

@screeley44 screeley44 Awaiting requested review from screeley44

Assignees

@dims dims

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

On AWS Attach followed by a detach of same volume is stuck waiting for volume attachment on old device path
6 participants
@gnufied @k8s-ci-robot @jsafrane @jingxu97 @saad-ali @dims