Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta upgrade for feature gate VolumeSubpathEnvExpansion #76546

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Beta upgrade for feature gate VolumeSubpathEnvExpansion #76546

merged 1 commit into from
Apr 19, 2019

Conversation

kevtaylor
Copy link
Contributor

@kevtaylor kevtaylor commented Apr 13, 2019 •
edited
Loading

/kind api-change

What this PR does / why we need it:
Promotes VolumeSubpathEnvExpansion feature gate to beta state

Which issue(s) this PR fixes:
Fixes #64604

Related to feature: kubernetes/enhancements#559

Special notes for your reviewer:
As far as I am aware, the alpha testing was comprehensive, so no new tests have been introduced and
no extras envisaged unless some additional edge cases are identified.
The alpha suites have been executing without issue alongside node tests in alpha state.

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kevtaylor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevtaylor
Copy link
Contributor Author

/assign @msau42
/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt April 13, 2019 16:09
@kevtaylor kevtaylor changed the title Beta upgrade for feature date VolumeSubpathEnvExpansion Beta upgrade for feature gate VolumeSubpathEnvExpansion Apr 13, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 13, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@kevtaylor
Copy link
Contributor Author

/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 13, 2019
@mattjmcnaughton
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2019
@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-verify

@mattjmcnaughton
Copy link
Contributor

I think its asking you to run hack/update-bazel.sh - alternatively, you could revert your change to staging/repos_generated.bzl (which I believe is unrelated to this diff, correct?)

@kevtaylor
Copy link
Contributor Author

@mattjmcnaughton I ran make update on the new fileset and that came out of it. You think I should just revert it?

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-Beta branch 2 times, most recently from b000e22 to 6ff8308 Compare April 15, 2019 07:43
@kevtaylor
Copy link
Contributor Author

@msau42 Please can you advise whether I should have changed the NodeAlphaFeature to NodeFeature? And also, whether there are any changes required to test-infra to test the beta feature

liggitt
liggitt reviewed Apr 15, 2019
View reviewed changes
test/e2e/common/expansion.go Outdated
@@ -157,7 +157,7 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
Description: Make sure a container's subpath can be set using an
expansion of environment variables.
*/
It("should allow substituting values in a volume subpath [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion]", func() {
It("should allow substituting values in a volume subpath [Feature:VolumeSubpathEnvExpansion]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once a feature is enabled by default, do we drop the [Feature:...] tag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would actually exercise the feature by default in CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, let's drop [Feature:VolumeSubpathEnvExpansion] too so that it will run by default

@liggitt
Copy link
Member

liggitt commented Apr 15, 2019

feature gate and API doc changes lgtm

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-Beta branch from 6ff8308 to 6c56428 Compare April 16, 2019 06:58
@kevtaylor
Copy link
Contributor Author

@liggitt Removed the Feature annotation and I can now see some activity in pull-kubernetes-e2e-gce but that excludes [Slow], so 5 of the 6 tests get skipped. Is there something we can trigger to test those before merge ?
Also, before, this suite would run in the Node tests due to the NodeAlphaFeature annotation. Do we need to do something additional to remain in that suite ? They all looked skipped in pull-kubernetes-node-e2e

@kevtaylor kevtaylor mentioned this pull request Apr 16, 2019
Merged
@msau42
Copy link
Member

msau42 commented Apr 16, 2019

that excludes [Slow]

Can you add [sig-storage] tag to the test cases? Then we can run it as part of the pull-kubernetes-e2e-gce-storage-slow optional job

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-Beta branch from 6c56428 to 59054c9 Compare April 16, 2019 17:05
@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

@msau42
Copy link
Member

msau42 commented Apr 16, 2019

Also, before, this suite would run in the Node tests due to the NodeAlphaFeature annotation. Do we need to do something additional to remain in that suite ? They all looked skipped in pull-kubernetes-node-e2e

I think pull node e2e jobs only run node conformance tests. We can get this to run in node CI jobs though by adding a "[NodeFeature:SubpathExpansion]" tag.

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-Beta branch from 59054c9 to bb5b4ad Compare April 17, 2019 06:42
@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

2 similar comments
@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

@kevtaylor
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-storage-slow

@k8s-ci-robot
Copy link
Contributor

@kevtaylor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-storage-slow bb5b4ad link /test pull-kubernetes-e2e-gce-storage-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msau42
Copy link
Member

msau42 commented Apr 17, 2019

fyi, i'm increasing the timeout of the pull job here: kubernetes/test-infra#12242

@msau42
Copy link
Member

msau42 commented Apr 17, 2019

/retest

@msau42
Copy link
Member

msau42 commented Apr 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@liggitt
Copy link
Member

liggitt commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevtaylor, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit f3ec8f0 into kubernetes:master Apr 19, 2019
@wojtek-t wojtek-t mentioned this pull request Apr 27, 2019
Closed
@kevtaylor kevtaylor mentioned this pull request May 28, 2019
Closed
@kevtaylor kevtaylor mentioned this pull request Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@liggitt liggitt liggitt left review comments

@davidopp davidopp Awaiting requested review from davidopp

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade VolumeSubpathEnvExpansion to Beta
6 participants
@kevtaylor @k8s-ci-robot @fejta-bot @mattjmcnaughton @liggitt @msau42