-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic when removing docker images #75367
Conversation
Why does docker return nil with no error? Is this a change caused by docker upgrade? |
@yujuhong Right, it comes from Docker after upgrading. Anyway, dockershim shouldn't panic. /retest |
This is actually a workaround for kubernetes/kubernetes#75367. It would be removed after the upstream PR #75367 got merged.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.14 Added to v1.14 since it's a critical bug fixes. It should also be cherry picked to stable releases. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Dockershim may be panic when deleting images. This PR fixes it by adding a check before using the imageInspect.
Refer kubernetes-sigs/cri-tools#445.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig node
/kind bug
/assign @Random-Liu @yujuhong