-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase core master image from debian to distroless #75306
Conversation
Hi @yuwenma. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
37a6e1d
to
89a90b8
Compare
89a90b8
to
215f327
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuwenma If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
215f327
to
1e9c535
Compare
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@yuwenma: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
@yuwenma @liggitt -- What's the current status on this? |
/hold I don't see any evidence that distroless images support architectures other than amd64 (Please correct me if i am wrong!!!) cc @tallclair |
oof yeah, inspecting the images in cloud console shows only amd64 manifests (sampled a few). |
@BenTheElder someone ported to arm arch as well https://github.com/discolix/discolix but that's it other arches don't work either cc @tallclair |
Looks like i missed a nuance, even if the manifest says amd64 like Ben observed, looks like the key here is |
We still have to be careful to make sure the release images have the right
architecture metadata.
…On Mon, Apr 27, 2020, 07:15 Davanum Srinivas ***@***.***> wrote:
Looks like i missed a nuance, even if the manifest says amd64 like Ben
observed, looks like the key here is :static
GoogleContainerTools/distroless#346
<GoogleContainerTools/distroless#346>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75306 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK4PEWUUEP62N673MPLROWHRDANCNFSM4G5QFVNA>
.
|
/hold cancel Right @BenTheElder |
Seems like |
Even with no binary base:
#87325
…On Mon, Apr 27, 2020, 16:46 Jake Sanders ***@***.***> wrote:
Seems like distroless:static should be trivially multi-arch-friendly,
though that obviously doesn't extend to :base and others with bundled
libs and runtimes. I'll follow up to see how difficult it would be to push
a manifest list to gcr.io/distroless/static:latest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75306 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK54DWLRNLAQQR6JX4LROYKMTANCNFSM4G5QFVNA>
.
|
@BenTheElder right, it'd require a manifest list to be pushed to the base image repo. |
needs rebase |
Note that before we merge this PR - Revert "Revert "Revert "[Re-Apply][Distroless] Convert the GCE manifests for master containers.""" - needs to be Reverted again! |
@dims: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is part of the effort on rebasing kubernetes images to distroless/static. See this KEP for details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: