-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eclass task 1: clean up old code #71399
Conversation
/assign @Huang-Wei |
/priority important-soon |
a3bab97
to
63bbe9c
Compare
/approve lgtm overall :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks! We still need someone from sig-testing to review. Kindly ping @jberkus, any bandwidth? The deleted e2e tests are not enabled by default, so I think it's quite safe. :-) |
@msau42 FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks, @resouer! There is a small conflict that should be resolved.
lgtm! |
a534cda
to
af44761
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, ixdy, k82cn, resouer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Harry Zhang <[email protected]> Co-authored-by: Wang Qingcan <[email protected]>
af44761
to
797601d
Compare
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
🎆 🍾 |
The new implementation is just by handy, would be out very shortly :-) |
Long live equivalence class!
Since new design of eclass is out , it's now safe to remove the old eclass related code. Then PRs of new design can follow up.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Task 1 of #68720
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #71013
Special notes for your reviewer:
cc @denkensk @Huang-Wei @bsalamat
Marked as WIP since we need to make sure the clean up is complete and tests are happy. Will be ready for review after that.
Does this PR introduce a user-facing change?: