-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nodeport repair for ESIPP services #64349
Fix nodeport repair for ESIPP services #64349
Conversation
/cc @bowei |
/assign wojtek-t |
/cc @MrHohn |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, nicksardo, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@nicksardo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
After upgrading to a version with this fix, all services with overlapping nodeports will see events such as
|
Automatic merge from submit-queue. Fix nodeport repair for ESIPP services **What this PR does / why we need it**: The nodeport allocation repair controller does not scrape the `Service.Spec.healthCheckNodePort` value and would remove the allocation from memory and etcd after 10 minutes. This opens the door for other services to use the same nodeport and cause collisions. **Which issue(s) this PR fixes**: Fixes #54885 Similar to #64349 **Release note**: ```release-note Fix issue of colliding nodePorts when the cluster has services with externalTrafficPolicy=Local ```
What this PR does / why we need it:
The nodeport allocation repair controller does not scrape the
Service.Spec.healthCheckNodePort
value and would remove the allocation from memory and etcd after 10 minutes. This opens the door for other services to use the same nodeport and cause collisions.Which issue(s) this PR fixes:
Fixes #54885
Release note: