Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for LeaderElect for kube-scheduler #60524

Conversation

dims
Copy link
Member

@dims dims commented Feb 27, 2018

What this PR does / why we need it:

kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring:

efb2bb7

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59729

Special notes for your reviewer:

Release note:

kube-scheduler: restores default leader election behavior. leader-elect command line parameter should "true"

kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring:

efb2bb7
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 27, 2018
@dims
Copy link
Member Author

dims commented Feb 27, 2018

/assign @liggitt
/assign @mtaufen

@liggitt
Copy link
Member

liggitt commented Feb 27, 2018

cc @kubernetes/sig-scheduling-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 27, 2018
@liggitt liggitt added this to the v1.9 milestone Feb 27, 2018
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 27, 2018
@liggitt
Copy link
Member

liggitt commented Feb 27, 2018

/lgtm

needs cherry-pick to 1.9, right?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@dims
Copy link
Member Author

dims commented Feb 27, 2018

@liggitt yep, here it is #60526

@mtaufen
Copy link
Contributor

mtaufen commented Feb 27, 2018

/retest

@mtaufen
Copy link
Contributor

mtaufen commented Feb 27, 2018

/status approve-for-milestone

@bsalamat
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@resouer
Copy link
Contributor

resouer commented Feb 28, 2018

@dims We need to do cherry pick now

@dims
Copy link
Member Author

dims commented Feb 28, 2018

@resouer the cherry pick is here #60526

@mtaufen
Copy link
Contributor

mtaufen commented Feb 28, 2018

This isn't merging because it doesn't have status/approved-for-milestone.
Someone with permission to do that needs to add the label.

@liggitt
Copy link
Member

liggitt commented Feb 28, 2018

this is a bugfix that is required for 1.10 and in process to be backported to 1.9
/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @dims @liggitt @mtaufen

Pull Request Labels
  • sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@BenTheElder
Copy link
Member

/test pull-kubernetes-bazel-build
/test pull-kubernetes-bazel-test

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@mtaufen
Copy link
Contributor

mtaufen commented Mar 1, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@dims
Copy link
Member Author

dims commented Mar 1, 2018

/test pull-kubernetes-integration

@BenTheElder
Copy link
Member

#60614
/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 58731ae into kubernetes:master Mar 1, 2018
@k8s-github-robot
Copy link

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@davidopp
Copy link
Member

/approve

jpbetz added a commit that referenced this pull request Mar 20, 2018
…pstream-release-1.9

Automated cherry pick of #60524: Temporary fix for LeaderElect for kube-scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-scheduler defaults --lead-elect to false whereas kube-controller-manager defaults to true
9 participants