Disable Docker's health check until we officially support it #50796

yguo0905 · 2017-08-16T20:31:56Z

Tested locally.

Without this PR:

CONTAINER ID        IMAGE                                                  COMMAND                  CREATED             STATUS                     PORTS               NAMES
afdd796ddddc        gcr.io/ygg-gke-dev/nginx-healthcheck                   "nginx -g 'daemon ..."   5 minutes ago       Up 5 minutes (healthy)                       k8s_test-container_test-pod_default_8a1ad225-82bf-11e7-becb-480fcf514648_0

With this PR:

e3fb2437555f        gcr.io/ygg-gke-dev/nginx-healthcheck                   "nginx -g 'daemon ..."   10 seconds ago      Up 9 seconds                            k8s_test-container_test-pod_default_de82e83c-82c0-11e7-b3fc-480fcf514648_0

Release note:

Disable Docker's health check until we officially support it.

/assign @yujuhong
/assign @dchen1107

dchen1107 · 2017-08-16T20:42:14Z

pkg/kubelet/dockershim/docker_container.go

@@ -131,6 +131,10 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi
 			OpenStdin: config.Stdin,
 			StdinOnce: config.StdinOnce,
 			Tty:       config.Tty,
+			// Disable Docker's health check until we officially support it.
+			Healthcheck: &dockercontainer.HealthConfig{


Is this compatible with docker 1.10 and 1.11?

This is the compatibility between new docker client API and old docker daemon, which should not be an issue?

But on the other hand, to cherry-pick this into 1.7 and 1.6, we need #48308..

Unfortunately, the docker-related code changed a lot in the past 3 releases. Updating the docker client for each release will be a completely different PR....
I think it might be too intrusive. Let's think it through first...

yujuhong · 2017-08-16T22:46:29Z

pkg/kubelet/dockershim/docker_container.go

@@ -131,6 +131,10 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi
 			OpenStdin: config.Stdin,
 			StdinOnce: config.StdinOnce,
 			Tty:       config.Tty,
+			// Disable Docker's health check until we officially support it.


Add the issue number in the comment #25829

Done. Added a link.

yujuhong · 2017-08-16T22:46:39Z

/retest
/approve

yujuhong · 2017-08-17T00:33:17Z

LGTM, but leaving @dchen1107 a chance to object

/retest

dchen1107 · 2017-08-17T17:00:00Z

/lgtm

k8s-github-robot · 2017-08-17T17:00:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yguo0905, yujuhong

Associated issue: 50703

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/kubelet/OWNERS~~ [dchen1107,yujuhong]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-17T19:18:31Z

Automatic merge from submit-queue (batch tested with PRs 50563, 50698, 50796)

asacbp · 2017-12-11T09:09:02Z

pkg/kubelet/dockershim/docker_container.go

+			// (https://github.com/kubernetes/kubernetes/issues/25829).
+			Healthcheck: &dockercontainer.HealthConfig{
+				Test: []string{"NONE"},
+			},


fwiw, this causes lots of warnings in docker log like:

Dec 11 08:50:29 HOSTNAME dockerd[14450]: time="2017-12-11T08:50:29.993217562+01:00" level=warning msg="Unknown healthcheck type 'NONE' (expected 'CMD') in container XXXXX"

is this really the cleanest way to tell docker to not use the healthcheck?

@asacbp - that's what they are recommending, https://github.com/docker/engine-api/blob/master/types/container/config.go#L16 So maybe worth asking on the docker github issues?

This has just been fixed in docker, but hasn't been included in any release yet.
moby/moby#35533

k8s-ci-robot assigned dchen1107 and yujuhong Aug 16, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2017

dchen1107 reviewed Aug 16, 2017

View reviewed changes

yujuhong reviewed Aug 16, 2017

View reviewed changes

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2017

Disables Docker's health check

fe06c7e

yguo0905 force-pushed the hc branch from bfe4a13 to fe06c7e Compare August 16, 2017 23:12

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2017

k8s-github-robot merged commit e86f43b into kubernetes:master Aug 17, 2017

yujuhong mentioned this pull request Sep 1, 2017

Disable Health Checks from Docker daemon to prevent conflict with liveliness probes. #50703

Closed

asacbp reviewed Dec 11, 2017

View reviewed changes

yosifkit mentioned this pull request Oct 3, 2018

HEALTHCHECK directive in Dockerfile docker-library/cassandra#76

Closed

wglambert mentioned this pull request Oct 23, 2018

Feature request: add HEALTHCHECK redis/docker-library-redis#91

Closed

heqg mentioned this pull request Jan 28, 2021

Is it necessary to disable the container health check function for sanbox like the service container #98497

Closed

heqg mentioned this pull request Mar 4, 2021

Container Health check set #99692

Closed

CharlieC3 mentioned this pull request Aug 17, 2021

Add Docker state updaters hirosystems/stacks-blockchain-api#658

Closed

fernandesGabriel mentioned this pull request Jan 12, 2022

Docker Exit renatomefi/php-fpm-healthcheck#43

Merged

3 tasks

shaunco mentioned this pull request Nov 6, 2023

Health Check should be in the Dockerfile and not docker-compose openfga/openfga#1117

Closed

rephus mentioned this pull request Jan 4, 2024

feat: add healthcheck to dockerfile lightdash/lightdash#8417

Closed

3 tasks

fumoboy007 mentioned this pull request Aug 26, 2024

Add a HEALTHCHECK to the images docker-library/postgres#1237

Open

ashfire908 mentioned this pull request Sep 28, 2024

Move healthcheck into Dockerfile wolveix/satisfactory-server#348

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Docker's health check until we officially support it #50796

Disable Docker's health check until we officially support it #50796

yguo0905 commented Aug 16, 2017 •

edited

Loading

dchen1107 Aug 16, 2017

yguo0905 Aug 16, 2017

yguo0905 Aug 16, 2017

yujuhong Aug 16, 2017

yujuhong Aug 16, 2017

yujuhong Aug 16, 2017

yguo0905 Aug 16, 2017

yujuhong commented Aug 16, 2017

yujuhong commented Aug 17, 2017

dchen1107 commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

asacbp Dec 11, 2017 •

edited

Loading

dims Dec 11, 2017

yujuhong Dec 11, 2017

Disable Docker's health check until we officially support it #50796

Disable Docker's health check until we officially support it #50796

Conversation

yguo0905 commented Aug 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yujuhong commented Aug 16, 2017

yujuhong commented Aug 17, 2017

dchen1107 commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

asacbp Dec 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yguo0905 commented Aug 16, 2017 •

edited

Loading

asacbp Dec 11, 2017 •

edited

Loading