Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fieldSelector podIP #50091

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 3, 2017

What this PR does / why we need it:
Currently the fieldSelector for Pod only support metadata.name, metadata.namespace, spec.nodeName, spec.restartPolicy and status.phase.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50075

Special notes for your reviewer:
/cc @wojtek-t @caesarxuchao @justinsb @lilic

Release note:

add fieldSelector podIP

@k8s-ci-robot
Copy link
Contributor

@dixudx: GitHub didn't allow me to request PR reviews from the following users: LiliC.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
Currently the fieldSelector for Pod only support metadata.name, metadata.namespace, spec.nodeName, spec.restartPolicy and status.phase.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50075

Special notes for your reviewer:
/cc @wojtek-t @caesarxuchao @justinsb @lilic

Release note:

add fieldSelector podIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 3, 2017
@justinsb
Copy link
Member

justinsb commented Aug 3, 2017

/ok-to-test

/lgtm

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 3, 2017

/test pull-kubernetes-e2e-gce-etcd3

@caesarxuchao
Copy link
Member

/retest

@dixudx
Copy link
Member Author

dixudx commented Aug 4, 2017

@deads2k @wojtek-t Needs your approval. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Aug 4, 2017

/assign @deads2k @wojtek-t

@deads2k
Copy link
Contributor

deads2k commented Aug 7, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dixudx, justinsb

Associated issue: 50075

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50091, 50231, 50238, 50236, 50243)

@k8s-github-robot k8s-github-robot merged commit 0df3f0e into kubernetes:master Aug 7, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 7, 2017

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws c6cafa5 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx dixudx deleted the fieldSelector_podIP branch August 14, 2017 01:58
@asymmetric
Copy link

How come this was not included in 1.7.4? Is it related to the test failure above or did it just get merged too late?

@dixudx
Copy link
Member Author

dixudx commented Aug 18, 2017

@asymmetric You can rebase this PR into v1.7.4. Or @wojtek-t shall we cherry-pick this PR into v1.7.4 or release-1.7?

@wojtek-t
Copy link
Member

I don't think this should be cherrypicked. This is not a bug fix - it's a feature.

@asymmetric
Copy link

@wojtek-t @dixudx so is the best course of action to just wait for a new release?

Or can this somehow be backported?

@dixudx
Copy link
Member Author

dixudx commented Aug 22, 2017

@asymmetric Prefer to rebuild apiserver by yourself instead of waiting for the new release. It could take couple of weeks or months to get it released.

Cherry-pick this PR into your desired Kubernetes version and make kube-apiserver.

@asymmetric
Copy link

asymmetric commented Aug 22, 2017

@dixudx I'm not asking for a cluster I'm running, rather for an operator I'm building that needs to run against upstream API servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get pod by filtering by its IP
9 participants