Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored mirror pods in PodPreset admission plugin #45958

Merged
merged 1 commit into from
May 20, 2017
Merged

Ignored mirror pods in PodPreset admission plugin #45958

merged 1 commit into from
May 20, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented May 17, 2017

What this PR does / why we need it:
Ignored mirror pods in PodPreset admission plugin.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #45925

Release note:

Ignored mirror pods in PodPreset admission plugin.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 17, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2017
@k82cn
Copy link
Member Author

k82cn commented May 17, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot verify test this

zhangxiaoyu-zidif
zhangxiaoyu-zidif reviewed May 17, 2017
View reviewed changes
plugin/pkg/admission/podpreset/admission.go
@@ -97,6 +97,11 @@ func (c *podPresetPlugin) Admit(a admission.Attributes) error {
if !ok {
return errors.NewBadRequest("Resource was marked with kind Pod but was unable to be converted")
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic looks good

@k82cn
Copy link
Member Author

k82cn commented May 18, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2017
@pwittrock
Copy link
Member

/approve

@pwittrock
Copy link
Member

/assign derekwaynecarr

@k82cn
Copy link
Member Author

k82cn commented May 19, 2017

/assign @derekwaynecarr

@k82cn
Copy link
Member Author

k82cn commented May 19, 2017

ping @derekwaynecarr for approval :).

@derekwaynecarr
Copy link
Member

fyi @pmorie @jpeeler

@derekwaynecarr
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, k82cn, pwittrock

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2017
@k82cn
Copy link
Member Author

k82cn commented May 20, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-ci-robot
Copy link
Contributor

@k82cn: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 9862cdb link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45346, 45903, 45958, 46042, 45975)

@k8s-github-robot k8s-github-robot merged commit 46a38b0 into kubernetes:master May 20, 2017
@k82cn k82cn deleted the k8s_45925 branch May 20, 2017 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxiaoyu-zidif zhangxiaoyu-zidif zhangxiaoyu-zidif left review comments

Assignees

@derekwaynecarr derekwaynecarr

@pwittrock pwittrock

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PodPreset admission plugin should ignore mirror pods
7 participants
@k82cn @pwittrock @derekwaynecarr @k8s-github-robot @k8s-ci-robot @zhangxiaoyu-zidif @eparis