Make fluentd a critical pod #41035
Merged
Make fluentd a critical pod #41035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
piosz
reviewed
Feb 6, 2017
| @@ -15,6 +15,11 @@ spec: | |||
| k8s-app: fluentd-gcp | |||
| kubernetes.io/cluster-service: "true" | |||
| version: v1.35 | |||
| # This annotation ensures that fluentd does not get evicted if the node | |||
There was a problem hiding this comment.
Please update also cluster/saltbase/salt/fluentd-gcp/fluentd-gcp.yaml. See comment from the first line.
There was a problem hiding this comment.
Done. Sorry and thanks for pointing out.
Signed-off-by: Vishnu kannan <[email protected]>
vishh
force-pushed
the
fluentd-critical
branch
from
d6d1b9f
to
10e7902
Compare
|
LGTM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vishh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: piosz, vishh Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@k8s-bot kops aws e2e test this |
|
@k8s-bot gce etcd3 e2e test this |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #40573
Based on #40655 (comment)