List objects in deterministic order

[ddysher]

Closes #3772

/cc @smarterclayton

[dchen1107]

Can you add / update testcase in etcd_tools_test.go for this?

[smarterclayton]

This may break default event behavior, which may be relying on the default sort. Can you verify? Another option is to make this a Boolean on EtcdHelper and set it on a per registry basis.

[ddysher]

@dchen1107 test updated

@smarterclayton I'll take a look later

[ddysher]

@smarterclayton What is the 'default event behavior'? For event, we sort all of them based on Timestamp in client: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubectl/sorted_event_list.go
So I think we are good here?

[smarterclayton]

Yeah I think so.

On Jan 27, 2015, at 3:42 PM, Deyuan Deng [email protected] wrote:

@smarterclayton What is the 'default event behavior'? For event, we sort all of them based on Timestamp in client: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubectl/sorted_event_list.go
So I think we are good here?

—
Reply to this email directly or view it on GitHub.

[ddysher]

Sounds good. PTAL

[dchen1107]

LGTM.