-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SETUP_NODE to True for node e2e docker validation test. #29435
Merged
k8s-github-robot
merged 1 commit into
kubernetes:master
from
Random-Liu:setup-node-for-docker-validation
Jul 23, 2016
Merged
Change SETUP_NODE to True for node e2e docker validation test. #29435
k8s-github-robot
merged 1 commit into
kubernetes:master
from
Random-Liu:setup-node-for-docker-validation
Jul 23, 2016
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
the
release-note-none
Denotes a PR that doesn't merit a release note.
label
Jul 22, 2016
k8s-github-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jul 22, 2016
LGTM |
@k8s-bot test this issue #IGNORE. |
Random-Liu
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jul 22, 2016
Apply LGTM based on #29435 (comment). |
Random-Liu
added
the
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
label
Jul 22, 2016
The test keeps failing, bump up the priority. |
GCE e2e build/test passed for commit 7b27358. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 7b27358. |
Automatic merge from submit-queue |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/node-e2e
area/test
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note-none
Denotes a PR that doesn't merit a release note.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuous node e2e docker validation test is failing because:
This is because jenkins is not added to docker user group.
For other images tested in node e2e, jenkins is added to docker user group when the images are initially created https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/environment/setup_host.sh#L102.
However, in node e2e docker validation test, we are using GCI image which doesn't do that.
So we should use the
SETUP_NODE
option to add user to docker group before test runningkubernetes/test/e2e_node/e2e_remote.go
Lines 150 to 159 in b6c8790
This is only one line change, could you help me review the PR? @wonderfly
Thanks a lot! :)