[FG:InPlacePodVerticalScaling] Add UpdatePodSandboxResources CRI method

[felipeagger]

What type of PR is this?

/kind feature

What this PR does / why we need it:

As of Kubernetes v1.20, the CRI has included support for in-place resizing of containers via the UpdateContainerResources API, which is implemented by both containerd and CRI-O. Additionally, the ContainerStatus message includes a ContainerResources field, which reports the current resource configuration of the container.

Even though pod-level cgroups are currently managed by the Kubelet, runtimes may rely need to be notified when the resource configuration changes.

Doc: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1287-in-place-update-pod-resources/README.md#cri-changes

Which issue(s) this PR fixes:

Fixes #128069

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Hi @felipeagger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[felipeagger]

@Karthik-K-N Where in the Kubelet will call UpdatePodSandboxResources after it has reconfigured the pod-level cgroups ?
Can you send me the function/file name?

[Karthik-K-N]

@Karthik-K-N Where in the Kubelet will call UpdatePodSandboxResources after it has reconfigured the pod-level cgroups ? Can you send me the function/file name?

I am not sure either, Need to explore, If I find I will update here. Thank you.

[felipeagger]

/cc @vinaykul
Can you help us please?

Where in the Kubelet will call UpdatePodSandboxResources after it has reconfigured the pod-level cgroups ?

inside kubeGenericRuntimeManager.createPodSandbox?

[vinaykul]

#128069

Please see:

kubernetes/pkg/kubelet/kuberuntime/kuberuntime_manager.go

Lines 693 to 724 in d67e654

	// Memory and CPU are updated separately because memory resizes may be ordered differently than CPU resizes.
	// If resize results in net pod resource increase, set pod cgroup config before resizing containers.
	// If resize results in net pod resource decrease, set pod cgroup config after resizing containers.
	// If an error occurs at any point, abort. Let future syncpod iterations retry the unfinished stuff.
	resizeContainers := func(rName v1.ResourceName, currPodCgLimValue, newPodCgLimValue, currPodCgReqValue, newPodCgReqValue int64) error {
	var err error
	if newPodCgLimValue > currPodCgLimValue {
	if err = setPodCgroupConfig(rName, true); err != nil {
	return err
	}
	}
	if newPodCgReqValue > currPodCgReqValue {
	if err = setPodCgroupConfig(rName, false); err != nil {
	return err
	}
	}
	if len(podContainerChanges.ContainersToUpdate[rName]) > 0 {
	if err = m.updatePodContainerResources(pod, rName, podContainerChanges.ContainersToUpdate[rName]); err != nil {
	klog.ErrorS(err, "updatePodContainerResources failed", "pod", format.Pod(pod), "resource", rName)
	return err
	}
	}
	if newPodCgLimValue < currPodCgLimValue {
	err = setPodCgroupConfig(rName, true)
	}
	if newPodCgReqValue < currPodCgReqValue {
	if err = setPodCgroupConfig(rName, false); err != nil {
	return err
	}
	}
	return err
	}

/cc @tallclair

[vinaykul]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felipeagger
Once this PR has been reviewed and has the lgtm label, please ask for approval from tallclair. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS
• staging/src/k8s.io/cri-api/OWNERS
• staging/src/k8s.io/cri-client/OWNERS
• test/e2e_node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[felipeagger]

@tallclair I made the adjusts, can you check? pls

[felipeagger]

@tallclair This function cannot be inline because the functions convertOverheadToLinuxResources and calculateSandboxResources are platform specific, and break on typechecker.

[k8s-ci-robot]

@felipeagger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-gce-cos-alpha-features	8d66773	link	false	/test pull-kubernetes-e2e-gce-cos-alpha-features
pull-kubernetes-kind-dra-all	8d66773	link	false	/test pull-kubernetes-kind-dra-all
pull-kubernetes-node-e2e-crio-cgrpv1-dra	8d66773	link	false	/test pull-kubernetes-node-e2e-crio-cgrpv1-dra
pull-kubernetes-kind-dra	8d66773	link	false	/test pull-kubernetes-kind-dra
pull-kubernetes-e2e-gci-gce-ingress	8d66773	link	false	/test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-node-e2e-crio-cgrpv2-dra-kubetest2	8d66773	link	false	/test pull-kubernetes-node-e2e-crio-cgrpv2-dra-kubetest2
pull-kubernetes-e2e-kind-kms	8d66773	link	false	/test pull-kubernetes-e2e-kind-kms
pull-kubernetes-conformance-image-test	8d66773	link	false	/test pull-kubernetes-conformance-image-test
pull-kubernetes-e2e-kind-ipvs	8d66773	link	false	/test pull-kubernetes-e2e-kind-ipvs
pull-kubernetes-e2e-gce-network-policies	8d66773	link	false	/test pull-kubernetes-e2e-gce-network-policies
pull-kubernetes-local-e2e	8d66773	link	false	/test pull-kubernetes-local-e2e
pull-kubernetes-node-e2e-containerd-1-7-dra	8d66773	link	false	/test pull-kubernetes-node-e2e-containerd-1-7-dra
pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2	8d66773	link	false	/test pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2
pull-kubernetes-e2e-gci-gce-ipvs	8d66773	link	false	/test pull-kubernetes-e2e-gci-gce-ipvs
pull-kubernetes-e2e-kind-nftables	8d66773	link	false	/test pull-kubernetes-e2e-kind-nftables
pull-kubernetes-node-e2e-crio-cgrpv2-dra	8d66773	link	false	/test pull-kubernetes-node-e2e-crio-cgrpv2-dra
pull-kubernetes-e2e-gce-storage-slow	8d66773	link	false	/test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-cross	8d66773	link	false	/test pull-kubernetes-cross
check-dependency-stats	8d66773	link	false	/test check-dependency-stats
pull-kubernetes-e2e-gce-storage-snapshot	8d66773	link	false	/test pull-kubernetes-e2e-gce-storage-snapshot
pull-publishing-bot-validate	8d66773	link	false	/test pull-publishing-bot-validate
pull-kubernetes-e2e-storage-kind-disruptive	8d66773	link	false	/test pull-kubernetes-e2e-storage-kind-disruptive
pull-kubernetes-e2e-gce-csi-serial	8d66773	link	false	/test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-capz-windows-master	27bfa7e	link	false	/test pull-kubernetes-e2e-capz-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[fedebongio]

/remove-sig api-machinery

[pohly]

/remove-wg device-management