-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(nodeunschedulable): register missing Pod event for NodeUnschedulable plugin #127427
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @macsko @alculquicondor to go thru the approver's approve. |
pkg/scheduler/framework/plugins/nodeunschedulable/node_unschedulable_test.go
Outdated
Show resolved
Hide resolved
90fd4b9
to
4959819
Compare
/lgtm |
LGTM label has been added. Git tree hash: 4d06697bb40f3d31049adb47d4759fa71a7e0af5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes two bugs in NodeUnschedulable:
Node/UpdateNodeLabel
like other plugins. As the added comment says, we should always addNode/UpdateNodeLabel
andNode/UpdteNodeTaint
when the plugin usesNode/Add
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
(It doesn't mention the second bug intentionally because it's just made and isn't released.)
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: