-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: fix a bug in defaulting apiserver "authorizaion-mode" #123555
kubeadm: fix a bug in defaulting apiserver "authorizaion-mode" #123555
Conversation
When the flag is defaulted before writing the apiserver manifest, the input "cfg" object should not be mutated. If the "cfg" is mutated, the upload ClusterConfiguration to the cluster will include the defaulting, which is not needed.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 82eaa1b74bd06213c2e1660095e35e6d58024e06
|
LGTM |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the flag is defaulted before writing the apiserver manifest, the input "cfg" object should not be mutated.
If the "cfg" is mutated, the upload ClusterConfiguration to the cluster will include the defaulting, which is not needed.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#3029
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: