Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4210: add e2e tests and add small fix for ImageGCMaxAge #123343

Merged
merged 5 commits into from
Feb 20, 2024
Merged

KEP-4210: add e2e tests and add small fix for ImageGCMaxAge #123343

merged 5 commits into from
Feb 20, 2024

Conversation

haircommander
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

this PR adds e2e tests for imageGCMaxAge KEP, as well as fix a bug where the kubelet would garbage collect images after restarting, as it didn't have an idea of how old the images are. A consequence is MaxAge GC won't trigger until the kubelet has been alive for the full MaxAge duration, which I think is better than over GC'ing

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update ImageGCMaxAge behavior in the kubelet to wait the MaxAge duration after the kubelet has restarted before garbage collecting

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/4210

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 16, 2024
@haircommander haircommander mentioned this pull request Feb 16, 2024
Open
8 tasks
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 16, 2024
kannon92
kannon92 reviewed Feb 16, 2024
View reviewed changes
test/e2e_node/image_gc_test.go Outdated
)

// var _ = SIGDescribe("ImageGarbageCollect [Serial][NodeFeature:GarbageCollect]", func() {
var _ = SIGDescribe("ImageGarbageCollect", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be serial due to you changing the kubelet config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops good catch, forgot to replace with the above comment 🙃

@haircommander haircommander force-pushed the image-gc-e2e-2 branch 2 times, most recently from 58efb8d to 6ca9fec Compare February 16, 2024 20:51
@kannon92
Copy link
Contributor

/triage accepted
/priority important-soon

Part of an accepted KEP.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 16, 2024
@kannon92
Copy link
Contributor

/lgtm
/assign @mrunalp @yujuhong @dchen1107 @SergeyKanzhelev

@k8s-ci-robot
Copy link
Contributor

@kannon92: GitHub didn't allow me to assign the following users: yujuhong.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/lgtm
/assign @mrunalp @yujuhong @dchen1107 @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92079fe17a9ce0dfe1dd5772fe1edbeb3cf526bb

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@haircommander
Copy link
Contributor Author

@haircommander any container runtime specific items here

nope there shouldn't be!

@haircommander
Copy link
Contributor Author

/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial

@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe5b522762c941e76b40bf74233823ed7b549ba8

@haircommander
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit d311ce0 into kubernetes:master Feb 20, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dims dims Awaiting requested review from dims

@yujuhong yujuhong Awaiting requested review from yujuhong

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@kannon92 kannon92 Awaiting requested review from kannon92

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@mrunalp mrunalp

@kannon92 kannon92

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@haircommander @kannon92 @k8s-ci-robot @mrunalp @dchen1107 @SergeyKanzhelev