Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy NetworkPolicy tests #118915

Merged
merged 1 commit into from
Jul 3, 2023
Merged

remove legacy NetworkPolicy tests #118915

merged 1 commit into from
Jul 3, 2023

Conversation

astoycos
Copy link
Contributor

@astoycos astoycos commented Jun 27, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes the legacy network policy tests and NetworkPolicy API tests (which were duplicated within network_policy_api.go) from network_legacy.go, intentionally leaving the [Feature:SCTPConnectivity] tests which don't have coverage in the new netpol suite.

Which issue(s) this PR fixes:

Fixes #114389

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The NetworkPolicyLegacy test suite (deprecated in v1.21) has now officially been removed in favor of the new table driven e2e tests.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot added area/network-policy Issues or PRs related to Network Policy subproject area/test sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 27, 2023
@astoycos
Copy link
Contributor Author

/sig/network

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 27, 2023
@astoycos
Copy link
Contributor Author

astoycos commented Jun 27, 2023 •
edited
Loading

/assign @jayunit100

I'm thinking this is the right short term action to take here... But ultimately all the tests from network_legacy.go should be converted to truth table tests OR just moved into network_policy.go right?

@astoycos
Copy link
Contributor Author

/assign @danwinship

@jayunit100
Copy link
Member

yeah sure. We can convert the SCTP ones over after this , ill do that unless someone else wants to take it up.

@astoycos
Copy link
Contributor Author

I'm happy to do it @jayunit100! I'll probably just need some pointers 👍

@aojea
Copy link
Member

aojea commented Jun 28, 2023

/approve

please add a release note indicating these tests are removed and replaced by the ... ones

@danwinship or Jay for final LGTM

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2023
@astoycos
Copy link
Contributor Author

/retest-required

@danwinship
Copy link
Contributor

intentionally leaving the [Feature:SCTPConnectivity] tests which don't have coverage in the new netpol suite.

that was true at one point but appears to have been fixed by #97897

@astoycos
remove legacy NetworkPolicy tests
84b3d9b 
This commit removes the legacy networkpolicy tests since they now have
complete appropriate coverage in the new netpol suite.

Signed-off-by: Andrew Stoycos <[email protected]>
@astoycos
Copy link
Contributor Author

Yep thanks I just double checked @danwinship looks like we can remove the legacy one in it's entirety 🥳

@astoycos
Copy link
Contributor Author

astoycos commented Jul 3, 2023

/retest-required

@danwinship
Copy link
Contributor

/lgtm
/approve
whew! finally!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7bc5bb0404d5fde6ac5e42ec11ed70d79049d4f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, astoycos, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member

aojea commented Jul 3, 2023

Kubernetes e2e suite: [It] [sig-apps] StatefulSet Basic StatefulSet functionality [StatefulSetBasic] Should recreate evicted statefulset [Conformance] expand_more 8s
Kubernetes e2e suite: [It] [sig-api-machinery] Watchers should observe an object deletion if it stops meeting the requirements of the selector [Conformance] expand_more
/test pull-kubernetes-conformance-kind-ipv6-parallel

@astoycos the release note is missing

Should not have do-not-merge/release-note-label-needed label.

@astoycos
Copy link
Contributor Author

astoycos commented Jul 3, 2023

Ah sorry @aojea I thought it was in like a follow up issue or something, doing it now 👍

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2023
@astoycos
Copy link
Contributor Author

astoycos commented Jul 3, 2023

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 8f79a3d into kubernetes:master Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 3, 2023
@npinaeva npinaeva mentioned this pull request Jul 4, 2023
Merged
@aojea aojea mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiraut abhiraut Awaiting requested review from abhiraut

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@danwinship danwinship

@jayunit100 jayunit100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/network-policy Issues or PRs related to Network Policy subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

We forgot to remove the old netpol tests that are covered by new matrix based tests
5 participants
@astoycos @k8s-ci-robot @jayunit100 @aojea @danwinship