kubectl explain should work for both cluster and namespace resources and without a GET method #118876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/kubectl
sig/cli
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
6 tasks
|
/assign @alexzielenski |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
ardaguclu
reviewed
Jun 26, 2023
alexzielenski
approved these changes
Jun 26, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 96445497d5ad8b6cf1f975fd4b51358edcc7181b
|
|
/cc @apelisse for approve |
|
@alexzielenski thx for the approve and the E2Es sound like a great idea! |
apelisse
reviewed
Jun 27, 2023
Comment on lines
9
to
10
| {{- /* /apis/<group>/<version>/<version>/namespaces/{namespace}/<resource> */ -}} | ||
| {{- /* /apis/<group>/<version>/<version>/namespaces/{namespace}/<resource>/{name} */ -}} |
There was a problem hiding this comment.
Suggested change
| {{- /* /apis/<group>/<version>/<version>/namespaces/{namespace}/<resource> */ -}} | |
| {{- /* /apis/<group>/<version>/<version>/namespaces/{namespace}/<resource>/{name} */ -}} | |
| {{- /* /apis/<group>/<version>/namespaces/{namespace}/<resource> */ -}} | |
| {{- /* /apis/<group>/<version>/namespaces/{namespace}/<resource>/{name} */ -}} |
is that it? Pretty sure the double-version is wrong?
There was a problem hiding this comment.
good catch! fortunately it was just a comment :)
…and without a GET method
k8s-ci-robot
removed
the
lgtm
|
sig-node failures |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fe5b24b2b61d3daaf7ef7e1af7bfa1bc5dec42af
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, atiratree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I think it is worth backporting this to 1.27. I have opened a PR with a cherry-pick: #118930 |
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 5, 2023
…18876-upstream-release-1.27 Automated cherry pick of #118876: kubectl explain should work for both cluster and namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
kubectl explain should work for both cluster and namespace resources and without a GET method
Which issue(s) this PR fixes:
Fixes ##118875
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: