Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add no resources found message to rollout-status command #117884

Merged
merged 2 commits into from
May 10, 2023
Merged

add no resources found message to rollout-status command #117884

merged 2 commits into from
May 10, 2023

Conversation

gxwilkerson33
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR adds no resource found message to kubectl rollout status when there are no resources of the specified kind

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1362

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed issue where there was no response or error from kubectl rollout status when there were no resources of specified kind.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @gxwilkerson33. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 9, 2023
@gxwilkerson33
Copy link
Contributor Author

/cc @ardaguclu

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2023
@ardaguclu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2023
@gxwilkerson33
Copy link
Contributor Author

/retest

@gxwilkerson33
Copy link
Contributor Author

/retest

pull-kubernetes-verify pod timed out

ardaguclu
ardaguclu reviewed May 10, 2023
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/rollout/rollout_status.go
@@ -228,4 +230,10 @@ func (o *RolloutStatusOptions) Run() error {
return err
})
})

if !resourceFound {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If err is not nil, we are still showing this warning message. I think, we can show this warning only when err is nil. What do you think?.

I mean would it be better something like;

if err != nil {
    return err
}
if !resourceFound {
....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think that's correct so we don't show a double message. Thanks!

@ardaguclu
Copy link
Member

Thanks @gxwilkerson33

/approve
/lgtm
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 10, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5defda8f9b01ff7fe779e7e815e5319afab6635c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, gxwilkerson33

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@ardaguclu
Copy link
Member

/tide merge-method-squash

@ardaguclu
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit a557542 into kubernetes:master May 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 10, 2023
@gxwilkerson33 gxwilkerson33 deleted the kubectl-rollout-status-no-resources-message branch May 10, 2023 13:18
@bertinatto bertinatto mentioned this pull request Jun 20, 2023
Closed
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
@gxwilkerson33
add no resources found message to rollout-status command (kubernetes#…
c673887 
…117884)

* add no resources found message to rollout-status command

* return err if not nil before no resource message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 Awaiting requested review from seans3

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

Assignees

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

kubectl rollout status deployment has no response
3 participants
@gxwilkerson33 @k8s-ci-robot @ardaguclu