Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gcp and azure auth plugins #110013

Merged
merged 1 commit into from
May 12, 2022
Merged

Remove gcp and azure auth plugins #110013

merged 1 commit into from
May 12, 2022

Conversation

enj
Copy link
Member

@enj enj commented May 12, 2022 •
edited
Loading

Signed-off-by: Monis Khan [email protected]

What type of PR is this?

/kind cleanup
/kind deprecation
/triage accepted
/priority important-soon
/milestone v1.25
/assign @liggitt @mikedanese @ritazh @aramase

Fixes #103498

The `gcp` and `azure` auth plugins have been removed from client-go and kubectl. See https://github.com/Azure/kubelogin and https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke for details about the cloud-specific replacements.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 12, 2022
@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 12, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2022
@enj enj force-pushed the enj/i/remove_azure_gcp_auth_plugins branch from 7fe3194 to 916cf16 Compare May 12, 2022 14:07
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 12, 2022
liggitt
liggitt reviewed May 12, 2022
View reviewed changes
staging/src/k8s.io/client-go/go.mod
@@ -5,8 +5,6 @@ module k8s.io/client-go
go 1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent to see cloud provider deps drop out of client-go 🎉

@liggitt
Copy link
Member

liggitt commented May 12, 2022

/lgtm
/approve
for deps and gcp removal

cc @kubernetes/provider-azure for ack on azure plugin removal

@liggitt liggitt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@aojea
Copy link
Member

aojea commented May 12, 2022

/honk

@k8s-ci-robot
Copy link
Contributor

@aojea:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Member Author

enj commented May 12, 2022

/retest

2 similar comments
@enj
Copy link
Member Author

enj commented May 12, 2022

/retest

@ritazh
Copy link
Member

ritazh commented May 12, 2022

/retest

@ritazh
Copy link
Member

ritazh commented May 12, 2022

/lgtm
/approve
for azure removal

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Member Author

enj commented May 12, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

@enj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-windows-containerd 916cf16 link false /test pull-kubernetes-e2e-capz-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor

pull-kubernetes-e2e-capz-windows-containerd is currently broken and we're working to fix this.
Our CNI setup was using discovery.k8s.io/v1beta1 which was removed with #108797

@k8s-ci-robot k8s-ci-robot merged commit 2d08104 into kubernetes:master May 12, 2022
@jsturtevant jsturtevant mentioned this pull request May 12, 2022
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request May 17, 2022
Open
@liggitt liggitt mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cjcullen cjcullen Awaiting requested review from cjcullen

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@liggitt liggitt

@mikedanese mikedanese

@ritazh ritazh

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Remove gcp and azure auth plugins in v1.25
8 participants
@enj @liggitt @aojea @k8s-ci-robot @ritazh @marosset @mikedanese @aramase