Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] update to Go 1.17.6 #107613

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[go] update to Go 1.17.6 #107613

merged 1 commit into from
Jan 20, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 18, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update to Go 1.17.6

Part of kubernetes/release#2379

Which issue(s) this PR fixes:

Part of kubernetes/release#2379

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.6

/assign @dims @liggitt @justaugustus @cpanato
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 18, 2022
@k8s-ci-robot
Copy link
Contributor

@palnabarun: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2022
@palnabarun palnabarun force-pushed the releng/go-update-1.23 branch from 1d5029b to 19baeac Compare January 18, 2022 07:34
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jan 18, 2022
@palnabarun
[go] update to Go 1.17.6
38e9dce 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun palnabarun force-pushed the releng/go-update-1.23 branch from 19baeac to 38e9dce Compare January 18, 2022 07:43
This was referenced Jan 18, 2022
Closed
Merged
saschagrunert
saschagrunert approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2022
@palnabarun palnabarun mentioned this pull request Jan 18, 2022
Merged
@ameukam
Copy link
Member

ameukam commented Jan 18, 2022

/lgtm

@dims
Copy link
Member

dims commented Jan 18, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, palnabarun, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 531a28b into kubernetes:release-1.23 Jan 20, 2022
@palnabarun palnabarun deleted the releng/go-update-1.23 branch September 3, 2023 15:46
@palnabarun palnabarun restored the releng/go-update-1.23 branch September 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@justaugustus justaugustus

@saschagrunert saschagrunert

@liggitt liggitt

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@palnabarun @k8s-ci-robot @ameukam @dims @saschagrunert @justaugustus @liggitt