-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create aggregated ClusterRole for API Servers to allow getting Namespaces and Admission Webhooks #65442
Comments
@xmudrii: Reiterating the mentions to trigger a notification: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @cheftako |
+1 we should do that. Otherwise, aggregated API server builders will ship those roles. Not sure we want that from a security point of view. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/priority important-longterm |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm moving discussion from #65206 (comment) to this issue.
We think it would be a good idea to provide the aggregated ClusterRole, allowing the aggregated API servers to
get
,list
andwatch
Namespaces and Admission Webhooks. This role is generic for all API servers, and we're already using this pattern for the auth delegator.In this case, the API server operator would only have to create the appropriate ClusterRoleBinding, such as this one (example from
sample-apiserver
), compared to creating both the ClusterRole and the ClusterRoleBinding.In #65206, we have added an example manifest to the
sample-apiserver
repo, but as described above and as this is a generic role for all API servers, maybe we can make Kubernetes handle it.Without that role, the API server fails to start with the permissions errors (see #65206 for details).
I would like to take on this issue if this sounds okay.
/cc @deads2k @sttts @kubernetes/sig-auth-misc
/sig api-machinery
/sig auth
/kind feature
The text was updated successfully, but these errors were encountered: