Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haproxy and keepalived config #3060

Merged
merged 1 commit into from
May 16, 2024

Conversation

nijave
Copy link
Contributor

@nijave nijave commented May 4, 2024

Closes #3052

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @nijave!

It looks like this is your first PR to kubernetes/kubeadm 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubeadm has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @nijave. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2024
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/approve
/kind documentation

/cc @mbert

docs/ha-considerations.md Outdated Show resolved Hide resolved
docs/ha-considerations.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@neolit123: GitHub didn't allow me to request PR reviews from the following users: mbert.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

thanks
/approve
/kind documentation

/cc @mbert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 5, 2024
Copy link
Contributor

@mbert mbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As the timeout values are concerned, the reason for increasing them was given in the original ticket, however I'd still be interested to understand why they need to be that high.

@nijave
Copy link
Contributor Author

nijave commented May 5, 2024

Looks good to me. As the timeout values are concerned, the reason for increasing them was given in the original ticket, however I'd still be interested to understand why they need to be that high.

I'm not sure they necessarily need to be that high--I'm not sure if Kubernetes does any sort of keepalives but they would ideally be set around what k8s has

Edit looks like 1800s is what kube-apiserver is using for watches

--min-request-timeout int Default: 1800
An optional field indicating the minimum number of seconds a handler must keep a request open before timing it out. Currently only honored by the watch request handler, which picks a randomized value above this number as the connection timeout, to spread out load.

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/

There's also

--request-timeout duration Default: 1m0s
An optional field indicating the duration a handler must keep a request open before timing it out. This is the default request timeout for requests but may be overridden by flags such as --min-request-timeout for specific types of requests.

Edit 2:
With kubectl -w I do see some TCP traffic every 30 seconds so maybe there's some heartbeat/keepalive somewhere

@nijave
Copy link
Contributor Author

nijave commented May 5, 2024

I found kubernetes/kubernetes#95981 which would explain the 30s interval I'm seeing. I also asked in Kubernetes Slack https://kubernetes.slack.com/archives/C09NXKJKA/p1714925405232349

With that info, maybe 35s is more reasonable?

nijave added a commit to nijave/kubeadm that referenced this pull request May 5, 2024
@mbert
Copy link
Contributor

mbert commented May 5, 2024

I found kubernetes/kubernetes#95981 which would explain the 30s interval I'm seeing. I also asked in Kubernetes Slack https://kubernetes.slack.com/archives/C09NXKJKA/p1714925405232349

With that info, maybe 35s is more reasonable?

Yes, definitely.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits to one, then this can merge.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for the changes!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, nijave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

also thanks for the discussion about this @mbert @nijave

@neolit123
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit a9c4818 into kubernetes:main May 16, 2024
2 checks passed
@nijave nijave deleted the nv-ha-docs-haproxy2.4 branch May 16, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High Availability Considerations docs outdated
4 participants