kinder: add workflow for testing super-admin.conf #2949
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
neolit123
added
area/test
priority/important-soon
| # Ensure exit status of 0 | ||
| exit 0 |
There was a problem hiding this comment.
this was added last minute since sometimes passing a bash script to docker exec ... can result in random exit 1 statuses. even if e.g. the || exit 1 conditions are not met.
in some cases in the past we have seen docker exec ... mkdir ... failing randomly. it could be since we are calling docker exec a lot.
this forces an exit 0 status once the EOF for a script was reached,
i don't have a good explanation on what's going on.
There was a problem hiding this comment.
seems good as it reached the end of the script here.
|
/skip |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
| # Ensure exit status of 0 | ||
| exit 0 |
There was a problem hiding this comment.
seems good as it reached the end of the script here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| - -c | ||
| - | | ||
| set -x | ||
| CMD=docker exec {{ .vars.clusterName }}-control-plane-1 |
There was a problem hiding this comment.
i forgot to add quotes here.
it causes these CMD commands to fail, must have happened when i synced the template and the real workflow in ci/workflows.
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-super-admin-latest
will send a PR and self LGTM.
checks if the right files are generated, they have the correct certificates, that commands work without errors, etc. let me know if you think something else can be added.
tested locally with
kinder test workflow...xref #2414
test-infra PR:
kubernetes/test-infra#31161